16ab389e0bd11594059f8164a1477045ee625154 |
|
20-Apr-2016 |
Dake Gu <dake@google.com> |
Leanback: Add onGuidedActionCanceled onGuidedActionEdited() was called for the cancel case and confirm case, which was very confusing. Now deprecate this method and introduce onGuidedActionCanceled() method. Bug 28279231 Change-Id: I000491611b78a7aaba11ed61a5196ac34d7babd6
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
7709986aa43e891046183168a29f3e78d05abcc5 |
|
13-Apr-2016 |
Dake Gu <dake@google.com> |
Merge "GuidedStepFragment: differentiate clicking confirm button and cancel IME" into nyc-dev
|
9050c0fc8fbcd8ffe794915375efd5d2b96a0b2d |
|
02-Apr-2016 |
Dake Gu <dake@google.com> |
GuidedAction: Add save/restore support These cases will be saved automatically when autoRestore is not turned off on GuidedAction: 1. editable none password title 2. editable none password description 3. checked status 4. DatePicker's current selection Bug 27978256 Change-Id: If52f09e440538fb1d70a697eb69db371f02fd63f
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
bcc19824dc43bc2e1bf23bccb1263f8de87ac013 |
|
13-Apr-2016 |
Dake Gu <dake@google.com> |
GuidedStepFragment: differentiate clicking confirm button and cancel IME It used to call same onGuidedActionEditedAndProceed(). We now call different methods onGuidedActionEdited() onGuidedActionEditedAndProceed() Bug 27989656 Change-Id: If71352e86238a3a37845da3dd39256c518f4bf76
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
68a94e5c24b85f071fb57727954510fff0224d9c |
|
01-Apr-2016 |
Dake Gu <dake@google.com> |
GuidedStep: Fix addAsRoot() restoring problem Should only add fragment when savedInstanceState is not null. Since Activity.onCreate(savedInstanceState) will restore the FragmentManager and Framgnets. This CL dumps a warning and skip creating fragment when detected duplicated fragment. Bug 27972030 Change-Id: Iaa3177b0b70877ffea25e49d44f5be778a734a55
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
5b20ee9a8d24e70f5e9f2d134440885241a00586 |
|
01-Apr-2016 |
Dake Gu <dake@google.com> |
GuidedStep: Add back the focus in onResume When opening GuidedStepFragment from a Fragment with focus, GuidedStepFragment should requestFocus() when it is resumed. Bug 27970073 Change-Id: I96639ef806f5a9877d8c7dba6e49ea944f3099f7
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
015eaf265571c84b5d37311f58bc69b2eb4af8d4 |
|
30-Mar-2016 |
Dake Gu <dake@google.com> |
Fix GudiedStep GridView focus 2nd try Setting focusable in style/layout doesn't work for RecylerView, so set the attribute in GuidedActionsStyleList. Making grid view not focusable causing another issue: in Fragmet to Fragment transition, fragment.onResume() does not have any item view in the action list yet. So actionlist.requestFocus() gets ignored. Fixing this by declaring focusableViewAvailable() when RecylerView layout pass added focusable children. Bug 27886380 Change-Id: Ic95db8fb60d6e6c309f5a8d45642dbe0505d457b
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
8bfa8f6a659c1188a955ee185b13e777d29fb4d9 |
|
09-Feb-2016 |
Keyvan Amiri <keyvana@google.com> |
Framework Support Library: Ensure addSharedElement on TransitionHelper is only called on non-null views Prior to this, the null check was performed within the TransitionHelper's addSharedElement itself. Removed and transferred the null checking to the actual users of this method in GuidedStepFragment. Change-Id: I40def6c588364847edbbb30666b3e55f3f75dc52
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
e03d465a8a7b3e7c63a3487f2c05b99f28b8bec9 |
|
27-Jan-2016 |
susnata <susnata@google.com> |
Adding support for 2 different entrance transitions for GuidedStepFragment. This will be used to provide different visual treatment for GuidedStepFragment used in full/half screen mode. BUG: 24979579 Change-Id: Ib02254d686dc1e5313c4b83247b0e040b415c4ca
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
b984f3bcc6e81f30c8acd6b79313381c97339ec2 |
|
27-Jan-2016 |
Susnata Basak <susnata@google.com> |
Merge "Adding support to render GuidedStepFragment in full/half screen mode." into mnc-ub-dev
|
68d693985e85ee5eed18f78beaaadbfd9b8a4f13 |
|
25-Jan-2016 |
susnata <susnata@google.com> |
Adding support to render GuidedStepFragment in full/half screen mode. Bug: 24979579 Change-Id: Id286a2df026d4668356bf0aa94aba45f667e6006
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
b88b36aa081a500eb0e9d4be0bac85b33cd57dde |
|
05-Jan-2016 |
Dake Gu <dake@google.com> |
Adding datepicker in GuidedStepFragment Add GuidedDatePickerAction. Added a new VIEW_TYPE_DATE_PICKER in GuidedActionsStylist to handle GuidedDatePickerAction. The behavior is abstracted as a "click to activate/deactivate" widget, allowing subclass to support action other than DatePicker. The transition shares same code for drop down list (i.e. sub actions). Fix the generic Builder class problem, passing the concrete Builder class as generic parameter. Switch Picker to use standard activated status from a customized "expanded" attribute. And API review changes Bug: 25390757 Bug: 26509683 Bug: 26509387 Bug: 26509381 Change-Id: I35cb5f99a1e81acaa51366cf17b1353180c7a549
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
c3d11aea44660bf77326f6f07ebf11c6a19f7e1f |
|
16-Dec-2015 |
Dake Gu <dake@google.com> |
GuidedStepFragment: API tuning Add back the constant definition UI_STYLE_DEFAULT and mark it as deprecated. Change-Id: I68d3613cc96870360d53ade2451f0ceb88d64608
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
16d7e4b3b98569c16b53b41006345f5328112f66 |
|
16-Dec-2015 |
Dake Gu <dake@google.com> |
Merge "GuidedStepFragment: API tuning" into mnc-ub-dev
|
b5ba5532e1ece8fd051ad1066c8efb0d2c32936c |
|
15-Dec-2015 |
Dake Gu <dake@google.com> |
GuidedStepFragment: refactoring the focusable control 1. The actions list view does not need to be focusable. 2. It's a pain to disable focus left/right at verticalgridview level. For example when button actions are not visible, we should disable "focus out of right edge of main actions", when button actions are visible, we should enable "focus out of right edge of main actions". Moving the disable left/right logic to top layout make it lot cleaner. 3. Allow GuidedStepFragment subclass to customize isFocusOutStartAllowed or isFocusOutEndAllowed Bug: 26205201 Change-Id: I66ee6bee8c7abbfe97db0f9fdf8119615143f543
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
fd3fc2de015a0771537ff5100668941eb7c0ea00 |
|
14-Dec-2015 |
Dake Gu <dake@google.com> |
GuidedStepFragment: API tuning Hide all entry name related APIs. Those are used by the helper functions add/addAsRoot/finishGuidedStepFragments/ popBackStackToGuidedStepFragment. So apps either use the helper functions without knowing details of entry names, or they are on own. Change-Id: I2c0e1847bd25cc8db82488c87125ed20202aa6e8
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
fb23f1271e21761bb523948d9ea9c60c42ae7251 |
|
03-Dec-2015 |
Dake Gu <dake@google.com> |
GuidedStepFragment: Fix bug of sub actions focus Bug 26007404 Change-Id: Ib02b0cb3b8c92b30e822a7e7bb09e728ee82a473
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
1db5382081756ee276c1fb88f5ebdbc138b70249 |
|
02-Dec-2015 |
Dake Gu <dake@google.com> |
GuidedStepFragment: switch to material selector/ripple effect Use android:attr/selectableItemBackground for highlighting. Add a customized LinearLayout to support foreground before v23. Change-Id: Ie7f0448e3782853c20938826560aa137957cec49
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
1ed9dc77616514e20c51baa67a04adab42e4135e |
|
01-Dec-2015 |
Dake Gu <dake@google.com> |
GuidedStepFragment: Support animation of expanding sub actions Bug 24979518 Change-Id: Ie2d5bf7c25c30db89f6edffd6f71a26e9bca2090
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
be6eb618b4ba8a74d69fa04c77c717b1fcbea818 |
|
20-Nov-2015 |
Dake Gu <dake@google.com> |
GuidedStepFragment: support expand/collapse sub actions. Refactored GuidedActonsStylist.ViewHolder to be subclass of RecyclerView.ViewHolder, since GuidedActionsStylistis already assumes running in RecyclerView and adding scroll listener. There is no benefit of hiding RecyclerView. Added support to disable focus right / left in actions list view. We don't allow focus to the side buttons from sub actions. Also disable focus left so it won't be interpreted by a bottom BrowseFragment as open fast lane. Expand/collapse animation is yet to be added. Bug 24979518 Change-Id: I4309e63347e5b85b746477f988721fd4fca67943
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
e9401be71ad141fe76dc6064c58f8c64054fde8d |
|
21-Nov-2015 |
Dake Gu <dake@google.com> |
Reenable the workarond for framework fragment transition NPE The change was accidentally lost when I was removing the background fragment. Even without background fragment, still need this workaround for popping the first GuidedStepFragment. Change-Id: I30b17fed28abd70170559fe38af6f304dd766a8c
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
8e5ae27d6db125867640b672cc97d4a158fdfd48 |
|
18-Nov-2015 |
Dake Gu <dake@google.com> |
GuidedStep: sync selectorView translationY to focused view Current implementation assumes the focused view stays at fixed Y location. This is no longer true for expanded actions. This CL added support to sync selectorView Y position to focused view Y position. And due to the conflicts of both IME and scroll changes selector Y position, added common parent for change Y position for IME. Simplified selectorView animation implementation. Fixed bug that FadeAndShortSlide resets transitionY to 0. Fixed a mismatch of transitionName for guidedactions_root2. Remove unnecessary transition excludes since the views are already part of shared element transition. Tested by changing alignment rule of VerticalGridView. Change-Id: Id9f676e607aa6e3e9fed14e5b2687e4ad0951f45
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
7f43e18536eae40705d5c63830e9edb283f196ad |
|
16-Nov-2015 |
Dake Gu <dake@google.com> |
Theme dark version of brand color and guided actions background Follow the same strategy for defaultBrandColor/colorPrimary, introduce defaultBrandColorDark/colorPrimaryDark for details action background. Remove the code that auto-calculate dark version from defaultBrandColor. Simplify HeadersFragment and FullWidthdetailsOverviewRowPresenter code by using theme attribute in layout file. Follow the same naming convension, renamed guidedButtonActionsBackground to guidedActionsBackgroundDark for the "dark" version. Change-Id: I05f4ebc0903a3e10b860777c4eb44c4ac5547c9a
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
517a5ef1716efc7696a78dc9e0fff0312c47612d |
|
13-Nov-2015 |
Dake Gu <dake@google.com> |
GuidedStepFragment Refactoring background handling Changed the way background works, no longer use a dedicated BackgroundFragment, make background part of GuidedStepFragment. This need some tuning to make background view part of GuidedStepFragment transition (and excluded in some cases). Switch the default Ui Style to be UI_STYLE_ENTRANCE, allows app launches GuidedStepFragment without using helper method. Bug: 25671370 Change-Id: Ic68c0cc796d32df6919593d391a6fcfae99258ae
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
43e10e99e55c1c2eeca31fa13e9cc84160850f59 |
|
09-Nov-2015 |
Dake Gu <dake@google.com> |
GuidedStepFragment: allow move focus to button action list Add a GuidedActionAdapterGroup to maintain single ImeOpen flag and control next focus after editing. This would allow focus move between different action lists. Code refactoring moves editing logic from GuidedActionAdapter into GuidedActionAdapterGroup. Don't openIME in onKeyUp event, this causes timing issue that onKeyUp can be fired on a different view of keyDown. Move openIME into onClick event. Remove references to Adapter objects and view objects after Fragment onDestroyView(), fix potential View leaking. Change-Id: If89a7bf67bd62ff02d3ac2a2c64a1164d3fa76bd
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
0b3811639349fd5791a3f330b23b7e4b1c099c27 |
|
06-Nov-2015 |
Dake Gu <dake@google.com> |
GuidedStepFragment: morph action panel size change in fragment transaction Use shared element transition to morph between single action panel and double action panel. This requires different view Ids and transitionNames for two action panels in order to match shared element views correctly. b/24979563 Change-Id: I507c0329071317d0c1282f8892c0f4901d72c245
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
a97810e4e2ec2552f8247ebdadf323dae70d9e3f |
|
04-Nov-2015 |
Dake Gu <dake@google.com> |
GuidedStepFragment: multiple fixes: 1. Handle Keyboard ENTER key correctly. Go through the same logic that press enter icon in soft IME. 2. Add theme attribute for actions elevation value where SetupWraith need override as 0dip 3. Make EditText not focusable if action is not editable. Change-Id: I0e77487ba655c2d4ab729f180fe057b28e19e7e2
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
d14724d33d61385c27a00c31bbc67ad8eeb57b3c |
|
31-Oct-2015 |
Dake Gu <dake@google.com> |
GuidedStepFragment: two columns actions Duplicated action methods into another copy. The weight of actions width is controlled through theme: guidedActionContentWidthWeight, guidedActionContentWidthWeightTwoPanels. When there is one column: actions take 40% of screen width. When there are two columns: actions take 50% of screen width. Two actions backgrounds are controlled through theme: guidedActionsBackground, guidedButtonActionsBackground. b/24979563 Change-Id: I96486921c39693771c243b18ef9897aa750c65cb
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
fd23a2faf77c66a405a2b2974f719041feda9177 |
|
30-Oct-2015 |
Dake Gu <dake@google.com> |
GuidedStep: support popping multiple entries transition When finishGuidedStepFragments() is called, apply the UI_STYLE_ENTRANCE on current fragment so it will run the slide two sides returnTransition instead of slide one side returnTransition. Included a workaround of b/25375640 Change-Id: Ia8b15802a8e7a0c6f0466d1d5e6c8760c67483d0
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
37d4ed50ac446f9f8ad033fe56888dd6eb602d4d |
|
27-Oct-2015 |
Dake Gu <dake@google.com> |
Add convenient GuidedStepFragment finish methods finishGuidedStepFragments() would either finish activity or pops all GuidedStepFragments if was launched on top of other content. This made it possible that fragment does not care about whether it's launched in separate activity or on top of other content when it handles "finish" action. popBackStackToGuidedStepFragment() would pop several GuidedStepFragments from stack. Also fixed a bug of losing focus to content below GuidedStepFragment when switch to next action. Change-Id: I4345bfe9e4dac73b915f0f6318ce19d90098b45a
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
c1741246af607f6be2389056da0182c40f938348 |
|
17-Oct-2015 |
Dake Gu <dake@google.com> |
GuidedStepFragment: lots of editing improvements 1. Support editing description 2. add onGuidedActionEditedAndProceed() to control target action to focus on when IME finished. Currently we always focus to sibling action regardless whether the input is correct or not. 3. add notifyActionChanged() to update action item ui 4. Dim alpha of title when disabled Bug: 24979559 Bug: 25019347 Change-Id: I3258681d27761a3892f67f528539110bc7640c88
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
8403619efebe94666c0615c3fc85080a303acf80 |
|
14-Oct-2015 |
Dake Gu <dake@google.com> |
leanback: fix NPE of transition listener and clean up We actually can not support setListener(null) because transition class only provides addListener() and removeListener(). Details fragment adds a transition listener with null callback to the sharedelemententer transition. The bug was not discovered because leanback theme always specifies the sharedElementReturn transition. When sharedElementReturn transition is not specified. When pressing back, the null callback listener of sharedElementEnter transition are cloned into sharedElementReturn transition. Now we switch to use addListener/removeListener and change TransitionHelper methods to static. Bug 24202013 Change-Id: I7cc918013e4a357a59987ea9727bc03c15cb0097
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
ce4c2014042fe6e4723bab30741039848adcf4be |
|
09-Oct-2015 |
Dake Gu <dake@google.com> |
leanback: some javadoc fixes Bug 24804296 Bug 24806837 Bug 24807801 Bug 24806081 Bug 24804939 Change-Id: Ie611c6c663335628ba98c2571bfda494e80f47b3
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
bd0afce433ec8c219627522a5233d61bf27f7397 |
|
01-Oct-2015 |
Dake Gu <dake@google.com> |
Dont crash if no container for background fragment Bug 24570987 Change-Id: I67c759f9c64080671832ee6e3fe3ec9097d632df
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
2be7e6dbeec0a7c9fe1453cf6fd4f75a8c1c69f6 |
|
25-Sep-2015 |
Dake Gu <dake@google.com> |
GuidedStepFragment: slide from both side for UI_STYLE_ENTRANCE Simply check if the center of view in left to center of sceneRoot, then slide to the left, otherwise slide to the right. The position needs to be saved in captured transition values. b/21504593 Change-Id: I310b5c998a4f763c926f67086ca065b30d2a52ba
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
b749047cd5b6e0aa4514e5f17c053a256e20e1ca |
|
24-Sep-2015 |
Dake Gu <dake@google.com> |
Workaround for NPE inFragment.mContainerId The current workaround is not complete for opening guided step fragment on existing fragment. Added protection for both container id. Tested on Emulators of API22 and API23 Bug 24375784 Change-Id: I2ae73ea50bde2bee0e6c8f1a855e4f993ad5068b
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
42ae32908312e63b474963fef789017c75feae37 |
|
23-Sep-2015 |
Dake Gu <dake@google.com> |
Revert "Revert "GuidedStepFragment transition and new features"" This reverts commit d7b834d0339476a8867c6d14e67ed9a08d314e75.
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
d7b834d0339476a8867c6d14e67ed9a08d314e75 |
|
21-Sep-2015 |
Dake Gu <dake@google.com> |
Revert "GuidedStepFragment transition and new features" This reverts commit ce0bd5abebf662db7d8b42468009b227715698ec. Change-Id: I4ee14b2e4af37f707f6232fa0a5a1cb149c51540
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
ce0bd5abebf662db7d8b42468009b227715698ec |
|
01-Sep-2015 |
Dake Gu <dake@google.com> |
GuidedStepFragment transition and new features This is a re-iterate of use cases of GuidedStepFragment, new features including allowing app to add GuidedStepFragment on top of other content with a covering background fragment; using activity return transition to slide out content. Switched from fragment animation to fragment transition. Using transition will allow us to clone a support version of GuidedStepFragment that is impossible under fragment animation. Clearly defined three use cases: 1. When GuidedStepFragment is launched in empty activity. 2. When GuidedStepFragment is launched on top of other content. 3. When GuidedStepFragment is replacing exisitng GuidedStepFragment. For case 2, we need background to cover bottom content. Three cases has different transitions settings. Case 1 does not need Fragment enter transition because that's handled by activity transition. Bug 21504593 Bug 23976865 Change-Id: Id7a49d8706fb4b6d21f5f93db5ba9b21238b2c5e
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
4158705d3f0751d419a08c47a659abeae5f6c196 |
|
23-May-2015 |
Kris Giesing <kgiesing@google.com> |
Add support for editable actions to GuidedSteps b/21403345 Change-Id: Id46c94e237f461fcb96439c1dea033e3c2f2a1c4
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
751fc58ffff0614288c610fbd0767969abb9365f |
|
06-Apr-2015 |
Kris Giesing <kgiesing@google.com> |
Minor change to JavaDoc Change-Id: I9c6e892520171493fc8a9c0a8685d551ad2af222
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|
ebd3d9078dbaebd10a9506ca086435eb63e8a2d2 |
|
17-Feb-2015 |
Kris Giesing <kgiesing@google.com> |
Initial implementation of GuidedStepFragment b/18935698 Change-Id: I413f04bcac739768f79e22ab6b518399302a0d8b
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/GuidedStepFragment.java
|