[go: nahoru, domu]

1/*
2 * drivers/net/bond/bond_options.c - bonding options
3 * Copyright (c) 2013 Jiri Pirko <jiri@resnulli.us>
4 * Copyright (c) 2013 Scott Feldman <sfeldma@cumulusnetworks.com>
5 *
6 * This program is free software; you can redistribute it and/or modify
7 * it under the terms of the GNU General Public License as published by
8 * the Free Software Foundation; either version 2 of the License, or
9 * (at your option) any later version.
10 */
11
12#include <linux/errno.h>
13#include <linux/if.h>
14#include <linux/netdevice.h>
15#include <linux/spinlock.h>
16#include <linux/rcupdate.h>
17#include <linux/ctype.h>
18#include <linux/inet.h>
19#include "bonding.h"
20
21static int bond_option_active_slave_set(struct bonding *bond,
22					const struct bond_opt_value *newval);
23static int bond_option_miimon_set(struct bonding *bond,
24				  const struct bond_opt_value *newval);
25static int bond_option_updelay_set(struct bonding *bond,
26				   const struct bond_opt_value *newval);
27static int bond_option_downdelay_set(struct bonding *bond,
28				     const struct bond_opt_value *newval);
29static int bond_option_use_carrier_set(struct bonding *bond,
30				       const struct bond_opt_value *newval);
31static int bond_option_arp_interval_set(struct bonding *bond,
32					const struct bond_opt_value *newval);
33static int bond_option_arp_ip_target_add(struct bonding *bond, __be32 target);
34static int bond_option_arp_ip_target_rem(struct bonding *bond, __be32 target);
35static int bond_option_arp_ip_targets_set(struct bonding *bond,
36					  const struct bond_opt_value *newval);
37static int bond_option_arp_validate_set(struct bonding *bond,
38					const struct bond_opt_value *newval);
39static int bond_option_arp_all_targets_set(struct bonding *bond,
40					   const struct bond_opt_value *newval);
41static int bond_option_primary_set(struct bonding *bond,
42				   const struct bond_opt_value *newval);
43static int bond_option_primary_reselect_set(struct bonding *bond,
44					    const struct bond_opt_value *newval);
45static int bond_option_fail_over_mac_set(struct bonding *bond,
46					 const struct bond_opt_value *newval);
47static int bond_option_xmit_hash_policy_set(struct bonding *bond,
48					    const struct bond_opt_value *newval);
49static int bond_option_resend_igmp_set(struct bonding *bond,
50				       const struct bond_opt_value *newval);
51static int bond_option_num_peer_notif_set(struct bonding *bond,
52					  const struct bond_opt_value *newval);
53static int bond_option_all_slaves_active_set(struct bonding *bond,
54					     const struct bond_opt_value *newval);
55static int bond_option_min_links_set(struct bonding *bond,
56				     const struct bond_opt_value *newval);
57static int bond_option_lp_interval_set(struct bonding *bond,
58				       const struct bond_opt_value *newval);
59static int bond_option_pps_set(struct bonding *bond,
60			       const struct bond_opt_value *newval);
61static int bond_option_lacp_rate_set(struct bonding *bond,
62				     const struct bond_opt_value *newval);
63static int bond_option_ad_select_set(struct bonding *bond,
64				     const struct bond_opt_value *newval);
65static int bond_option_queue_id_set(struct bonding *bond,
66				    const struct bond_opt_value *newval);
67static int bond_option_mode_set(struct bonding *bond,
68				const struct bond_opt_value *newval);
69static int bond_option_slaves_set(struct bonding *bond,
70				  const struct bond_opt_value *newval);
71static int bond_option_tlb_dynamic_lb_set(struct bonding *bond,
72				  const struct bond_opt_value *newval);
73
74
75static const struct bond_opt_value bond_mode_tbl[] = {
76	{ "balance-rr",    BOND_MODE_ROUNDROBIN,   BOND_VALFLAG_DEFAULT},
77	{ "active-backup", BOND_MODE_ACTIVEBACKUP, 0},
78	{ "balance-xor",   BOND_MODE_XOR,          0},
79	{ "broadcast",     BOND_MODE_BROADCAST,    0},
80	{ "802.3ad",       BOND_MODE_8023AD,       0},
81	{ "balance-tlb",   BOND_MODE_TLB,          0},
82	{ "balance-alb",   BOND_MODE_ALB,          0},
83	{ NULL,            -1,                     0},
84};
85
86static const struct bond_opt_value bond_pps_tbl[] = {
87	{ "default", 1,         BOND_VALFLAG_DEFAULT},
88	{ "maxval",  USHRT_MAX, BOND_VALFLAG_MAX},
89	{ NULL,      -1,        0},
90};
91
92static const struct bond_opt_value bond_xmit_hashtype_tbl[] = {
93	{ "layer2",   BOND_XMIT_POLICY_LAYER2, BOND_VALFLAG_DEFAULT},
94	{ "layer3+4", BOND_XMIT_POLICY_LAYER34, 0},
95	{ "layer2+3", BOND_XMIT_POLICY_LAYER23, 0},
96	{ "encap2+3", BOND_XMIT_POLICY_ENCAP23, 0},
97	{ "encap3+4", BOND_XMIT_POLICY_ENCAP34, 0},
98	{ NULL,       -1,                       0},
99};
100
101static const struct bond_opt_value bond_arp_validate_tbl[] = {
102	{ "none",		BOND_ARP_VALIDATE_NONE,		BOND_VALFLAG_DEFAULT},
103	{ "active",		BOND_ARP_VALIDATE_ACTIVE,	0},
104	{ "backup",		BOND_ARP_VALIDATE_BACKUP,	0},
105	{ "all",		BOND_ARP_VALIDATE_ALL,		0},
106	{ "filter",		BOND_ARP_FILTER,		0},
107	{ "filter_active",	BOND_ARP_FILTER_ACTIVE,		0},
108	{ "filter_backup",	BOND_ARP_FILTER_BACKUP,		0},
109	{ NULL,			-1,				0},
110};
111
112static const struct bond_opt_value bond_arp_all_targets_tbl[] = {
113	{ "any", BOND_ARP_TARGETS_ANY, BOND_VALFLAG_DEFAULT},
114	{ "all", BOND_ARP_TARGETS_ALL, 0},
115	{ NULL,  -1,                   0},
116};
117
118static const struct bond_opt_value bond_fail_over_mac_tbl[] = {
119	{ "none",   BOND_FOM_NONE,   BOND_VALFLAG_DEFAULT},
120	{ "active", BOND_FOM_ACTIVE, 0},
121	{ "follow", BOND_FOM_FOLLOW, 0},
122	{ NULL,     -1,              0},
123};
124
125static const struct bond_opt_value bond_intmax_tbl[] = {
126	{ "off",     0,       BOND_VALFLAG_DEFAULT},
127	{ "maxval",  INT_MAX, BOND_VALFLAG_MAX},
128	{ NULL,      -1,      0}
129};
130
131static const struct bond_opt_value bond_lacp_rate_tbl[] = {
132	{ "slow", AD_LACP_SLOW, 0},
133	{ "fast", AD_LACP_FAST, 0},
134	{ NULL,   -1,           0},
135};
136
137static const struct bond_opt_value bond_ad_select_tbl[] = {
138	{ "stable",    BOND_AD_STABLE,    BOND_VALFLAG_DEFAULT},
139	{ "bandwidth", BOND_AD_BANDWIDTH, 0},
140	{ "count",     BOND_AD_COUNT,     0},
141	{ NULL,        -1,                0},
142};
143
144static const struct bond_opt_value bond_num_peer_notif_tbl[] = {
145	{ "off",     0,   0},
146	{ "maxval",  255, BOND_VALFLAG_MAX},
147	{ "default", 1,   BOND_VALFLAG_DEFAULT},
148	{ NULL,      -1,  0}
149};
150
151static const struct bond_opt_value bond_primary_reselect_tbl[] = {
152	{ "always",  BOND_PRI_RESELECT_ALWAYS,  BOND_VALFLAG_DEFAULT},
153	{ "better",  BOND_PRI_RESELECT_BETTER,  0},
154	{ "failure", BOND_PRI_RESELECT_FAILURE, 0},
155	{ NULL,      -1},
156};
157
158static const struct bond_opt_value bond_use_carrier_tbl[] = {
159	{ "off", 0,  0},
160	{ "on",  1,  BOND_VALFLAG_DEFAULT},
161	{ NULL,  -1, 0}
162};
163
164static const struct bond_opt_value bond_all_slaves_active_tbl[] = {
165	{ "off", 0,  BOND_VALFLAG_DEFAULT},
166	{ "on",  1,  0},
167	{ NULL,  -1, 0}
168};
169
170static const struct bond_opt_value bond_resend_igmp_tbl[] = {
171	{ "off",     0,   0},
172	{ "maxval",  255, BOND_VALFLAG_MAX},
173	{ "default", 1,   BOND_VALFLAG_DEFAULT},
174	{ NULL,      -1,  0}
175};
176
177static const struct bond_opt_value bond_lp_interval_tbl[] = {
178	{ "minval",  1,       BOND_VALFLAG_MIN | BOND_VALFLAG_DEFAULT},
179	{ "maxval",  INT_MAX, BOND_VALFLAG_MAX},
180	{ NULL,      -1,      0},
181};
182
183static const struct bond_opt_value bond_tlb_dynamic_lb_tbl[] = {
184	{ "off", 0,  0},
185	{ "on",  1,  BOND_VALFLAG_DEFAULT},
186	{ NULL,  -1, 0}
187};
188
189static const struct bond_option bond_opts[] = {
190	[BOND_OPT_MODE] = {
191		.id = BOND_OPT_MODE,
192		.name = "mode",
193		.desc = "bond device mode",
194		.flags = BOND_OPTFLAG_NOSLAVES | BOND_OPTFLAG_IFDOWN,
195		.values = bond_mode_tbl,
196		.set = bond_option_mode_set
197	},
198	[BOND_OPT_PACKETS_PER_SLAVE] = {
199		.id = BOND_OPT_PACKETS_PER_SLAVE,
200		.name = "packets_per_slave",
201		.desc = "Packets to send per slave in RR mode",
202		.unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ROUNDROBIN)),
203		.values = bond_pps_tbl,
204		.set = bond_option_pps_set
205	},
206	[BOND_OPT_XMIT_HASH] = {
207		.id = BOND_OPT_XMIT_HASH,
208		.name = "xmit_hash_policy",
209		.desc = "balance-xor, 802.3ad, and tlb hashing method",
210		.values = bond_xmit_hashtype_tbl,
211		.set = bond_option_xmit_hash_policy_set
212	},
213	[BOND_OPT_ARP_VALIDATE] = {
214		.id = BOND_OPT_ARP_VALIDATE,
215		.name = "arp_validate",
216		.desc = "validate src/dst of ARP probes",
217		.unsuppmodes = BIT(BOND_MODE_8023AD) | BIT(BOND_MODE_TLB) |
218			       BIT(BOND_MODE_ALB),
219		.values = bond_arp_validate_tbl,
220		.set = bond_option_arp_validate_set
221	},
222	[BOND_OPT_ARP_ALL_TARGETS] = {
223		.id = BOND_OPT_ARP_ALL_TARGETS,
224		.name = "arp_all_targets",
225		.desc = "fail on any/all arp targets timeout",
226		.values = bond_arp_all_targets_tbl,
227		.set = bond_option_arp_all_targets_set
228	},
229	[BOND_OPT_FAIL_OVER_MAC] = {
230		.id = BOND_OPT_FAIL_OVER_MAC,
231		.name = "fail_over_mac",
232		.desc = "For active-backup, do not set all slaves to the same MAC",
233		.flags = BOND_OPTFLAG_NOSLAVES,
234		.values = bond_fail_over_mac_tbl,
235		.set = bond_option_fail_over_mac_set
236	},
237	[BOND_OPT_ARP_INTERVAL] = {
238		.id = BOND_OPT_ARP_INTERVAL,
239		.name = "arp_interval",
240		.desc = "arp interval in milliseconds",
241		.unsuppmodes = BIT(BOND_MODE_8023AD) | BIT(BOND_MODE_TLB) |
242			       BIT(BOND_MODE_ALB),
243		.values = bond_intmax_tbl,
244		.set = bond_option_arp_interval_set
245	},
246	[BOND_OPT_ARP_TARGETS] = {
247		.id = BOND_OPT_ARP_TARGETS,
248		.name = "arp_ip_target",
249		.desc = "arp targets in n.n.n.n form",
250		.flags = BOND_OPTFLAG_RAWVAL,
251		.set = bond_option_arp_ip_targets_set
252	},
253	[BOND_OPT_DOWNDELAY] = {
254		.id = BOND_OPT_DOWNDELAY,
255		.name = "downdelay",
256		.desc = "Delay before considering link down, in milliseconds",
257		.values = bond_intmax_tbl,
258		.set = bond_option_downdelay_set
259	},
260	[BOND_OPT_UPDELAY] = {
261		.id = BOND_OPT_UPDELAY,
262		.name = "updelay",
263		.desc = "Delay before considering link up, in milliseconds",
264		.values = bond_intmax_tbl,
265		.set = bond_option_updelay_set
266	},
267	[BOND_OPT_LACP_RATE] = {
268		.id = BOND_OPT_LACP_RATE,
269		.name = "lacp_rate",
270		.desc = "LACPDU tx rate to request from 802.3ad partner",
271		.flags = BOND_OPTFLAG_IFDOWN,
272		.unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_8023AD)),
273		.values = bond_lacp_rate_tbl,
274		.set = bond_option_lacp_rate_set
275	},
276	[BOND_OPT_MINLINKS] = {
277		.id = BOND_OPT_MINLINKS,
278		.name = "min_links",
279		.desc = "Minimum number of available links before turning on carrier",
280		.values = bond_intmax_tbl,
281		.set = bond_option_min_links_set
282	},
283	[BOND_OPT_AD_SELECT] = {
284		.id = BOND_OPT_AD_SELECT,
285		.name = "ad_select",
286		.desc = "803.ad aggregation selection logic",
287		.flags = BOND_OPTFLAG_IFDOWN,
288		.values = bond_ad_select_tbl,
289		.set = bond_option_ad_select_set
290	},
291	[BOND_OPT_NUM_PEER_NOTIF] = {
292		.id = BOND_OPT_NUM_PEER_NOTIF,
293		.name = "num_unsol_na",
294		.desc = "Number of peer notifications to send on failover event",
295		.values = bond_num_peer_notif_tbl,
296		.set = bond_option_num_peer_notif_set
297	},
298	[BOND_OPT_MIIMON] = {
299		.id = BOND_OPT_MIIMON,
300		.name = "miimon",
301		.desc = "Link check interval in milliseconds",
302		.values = bond_intmax_tbl,
303		.set = bond_option_miimon_set
304	},
305	[BOND_OPT_PRIMARY] = {
306		.id = BOND_OPT_PRIMARY,
307		.name = "primary",
308		.desc = "Primary network device to use",
309		.flags = BOND_OPTFLAG_RAWVAL,
310		.unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ACTIVEBACKUP) |
311						BIT(BOND_MODE_TLB) |
312						BIT(BOND_MODE_ALB)),
313		.set = bond_option_primary_set
314	},
315	[BOND_OPT_PRIMARY_RESELECT] = {
316		.id = BOND_OPT_PRIMARY_RESELECT,
317		.name = "primary_reselect",
318		.desc = "Reselect primary slave once it comes up",
319		.values = bond_primary_reselect_tbl,
320		.set = bond_option_primary_reselect_set
321	},
322	[BOND_OPT_USE_CARRIER] = {
323		.id = BOND_OPT_USE_CARRIER,
324		.name = "use_carrier",
325		.desc = "Use netif_carrier_ok (vs MII ioctls) in miimon",
326		.values = bond_use_carrier_tbl,
327		.set = bond_option_use_carrier_set
328	},
329	[BOND_OPT_ACTIVE_SLAVE] = {
330		.id = BOND_OPT_ACTIVE_SLAVE,
331		.name = "active_slave",
332		.desc = "Currently active slave",
333		.flags = BOND_OPTFLAG_RAWVAL,
334		.unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ACTIVEBACKUP) |
335						BIT(BOND_MODE_TLB) |
336						BIT(BOND_MODE_ALB)),
337		.set = bond_option_active_slave_set
338	},
339	[BOND_OPT_QUEUE_ID] = {
340		.id = BOND_OPT_QUEUE_ID,
341		.name = "queue_id",
342		.desc = "Set queue id of a slave",
343		.flags = BOND_OPTFLAG_RAWVAL,
344		.set = bond_option_queue_id_set
345	},
346	[BOND_OPT_ALL_SLAVES_ACTIVE] = {
347		.id = BOND_OPT_ALL_SLAVES_ACTIVE,
348		.name = "all_slaves_active",
349		.desc = "Keep all frames received on an interface by setting active flag for all slaves",
350		.values = bond_all_slaves_active_tbl,
351		.set = bond_option_all_slaves_active_set
352	},
353	[BOND_OPT_RESEND_IGMP] = {
354		.id = BOND_OPT_RESEND_IGMP,
355		.name = "resend_igmp",
356		.desc = "Number of IGMP membership reports to send on link failure",
357		.values = bond_resend_igmp_tbl,
358		.set = bond_option_resend_igmp_set
359	},
360	[BOND_OPT_LP_INTERVAL] = {
361		.id = BOND_OPT_LP_INTERVAL,
362		.name = "lp_interval",
363		.desc = "The number of seconds between instances where the bonding driver sends learning packets to each slave's peer switch",
364		.values = bond_lp_interval_tbl,
365		.set = bond_option_lp_interval_set
366	},
367	[BOND_OPT_SLAVES] = {
368		.id = BOND_OPT_SLAVES,
369		.name = "slaves",
370		.desc = "Slave membership management",
371		.flags = BOND_OPTFLAG_RAWVAL,
372		.set = bond_option_slaves_set
373	},
374	[BOND_OPT_TLB_DYNAMIC_LB] = {
375		.id = BOND_OPT_TLB_DYNAMIC_LB,
376		.name = "tlb_dynamic_lb",
377		.desc = "Enable dynamic flow shuffling",
378		.unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_TLB)),
379		.values = bond_tlb_dynamic_lb_tbl,
380		.flags = BOND_OPTFLAG_IFDOWN,
381		.set = bond_option_tlb_dynamic_lb_set,
382	},
383	{ }
384};
385
386/* Searches for an option by name */
387const struct bond_option *bond_opt_get_by_name(const char *name)
388{
389	const struct bond_option *opt;
390	int option;
391
392	for (option = 0; option < BOND_OPT_LAST; option++) {
393		opt = bond_opt_get(option);
394		if (opt && !strcmp(opt->name, name))
395			return opt;
396	}
397
398	return NULL;
399}
400
401/* Searches for a value in opt's values[] table */
402const struct bond_opt_value *bond_opt_get_val(unsigned int option, u64 val)
403{
404	const struct bond_option *opt;
405	int i;
406
407	opt = bond_opt_get(option);
408	if (WARN_ON(!opt))
409		return NULL;
410	for (i = 0; opt->values && opt->values[i].string; i++)
411		if (opt->values[i].value == val)
412			return &opt->values[i];
413
414	return NULL;
415}
416
417/* Searches for a value in opt's values[] table which matches the flagmask */
418static const struct bond_opt_value *bond_opt_get_flags(const struct bond_option *opt,
419						 u32 flagmask)
420{
421	int i;
422
423	for (i = 0; opt->values && opt->values[i].string; i++)
424		if (opt->values[i].flags & flagmask)
425			return &opt->values[i];
426
427	return NULL;
428}
429
430/* If maxval is missing then there's no range to check. In case minval is
431 * missing then it's considered to be 0.
432 */
433static bool bond_opt_check_range(const struct bond_option *opt, u64 val)
434{
435	const struct bond_opt_value *minval, *maxval;
436
437	minval = bond_opt_get_flags(opt, BOND_VALFLAG_MIN);
438	maxval = bond_opt_get_flags(opt, BOND_VALFLAG_MAX);
439	if (!maxval || (minval && val < minval->value) || val > maxval->value)
440		return false;
441
442	return true;
443}
444
445/**
446 * bond_opt_parse - parse option value
447 * @opt: the option to parse against
448 * @val: value to parse
449 *
450 * This function tries to extract the value from @val and check if it's
451 * a possible match for the option and returns NULL if a match isn't found,
452 * or the struct_opt_value that matched. It also strips the new line from
453 * @val->string if it's present.
454 */
455const struct bond_opt_value *bond_opt_parse(const struct bond_option *opt,
456					    struct bond_opt_value *val)
457{
458	char *p, valstr[BOND_OPT_MAX_NAMELEN + 1] = { 0, };
459	const struct bond_opt_value *tbl;
460	const struct bond_opt_value *ret = NULL;
461	bool checkval;
462	int i, rv;
463
464	/* No parsing if the option wants a raw val */
465	if (opt->flags & BOND_OPTFLAG_RAWVAL)
466		return val;
467
468	tbl = opt->values;
469	if (!tbl)
470		goto out;
471
472	/* ULLONG_MAX is used to bypass string processing */
473	checkval = val->value != ULLONG_MAX;
474	if (!checkval) {
475		if (!val->string)
476			goto out;
477		p = strchr(val->string, '\n');
478		if (p)
479			*p = '\0';
480		for (p = val->string; *p; p++)
481			if (!(isdigit(*p) || isspace(*p)))
482				break;
483		/* The following code extracts the string to match or the value
484		 * and sets checkval appropriately
485		 */
486		if (*p) {
487			rv = sscanf(val->string, "%32s", valstr);
488		} else {
489			rv = sscanf(val->string, "%llu", &val->value);
490			checkval = true;
491		}
492		if (!rv)
493			goto out;
494	}
495
496	for (i = 0; tbl[i].string; i++) {
497		/* Check for exact match */
498		if (checkval) {
499			if (val->value == tbl[i].value)
500				ret = &tbl[i];
501		} else {
502			if (!strcmp(valstr, "default") &&
503			    (tbl[i].flags & BOND_VALFLAG_DEFAULT))
504				ret = &tbl[i];
505
506			if (!strcmp(valstr, tbl[i].string))
507				ret = &tbl[i];
508		}
509		/* Found an exact match */
510		if (ret)
511			goto out;
512	}
513	/* Possible range match */
514	if (checkval && bond_opt_check_range(opt, val->value))
515		ret = val;
516out:
517	return ret;
518}
519
520/* Check opt's dependencies against bond mode and currently set options */
521static int bond_opt_check_deps(struct bonding *bond,
522			       const struct bond_option *opt)
523{
524	struct bond_params *params = &bond->params;
525
526	if (test_bit(params->mode, &opt->unsuppmodes))
527		return -EACCES;
528	if ((opt->flags & BOND_OPTFLAG_NOSLAVES) && bond_has_slaves(bond))
529		return -ENOTEMPTY;
530	if ((opt->flags & BOND_OPTFLAG_IFDOWN) && (bond->dev->flags & IFF_UP))
531		return -EBUSY;
532
533	return 0;
534}
535
536static void bond_opt_dep_print(struct bonding *bond,
537			       const struct bond_option *opt)
538{
539	const struct bond_opt_value *modeval;
540	struct bond_params *params;
541
542	params = &bond->params;
543	modeval = bond_opt_get_val(BOND_OPT_MODE, params->mode);
544	if (test_bit(params->mode, &opt->unsuppmodes))
545		netdev_err(bond->dev, "option %s: mode dependency failed, not supported in mode %s(%llu)\n",
546			   opt->name, modeval->string, modeval->value);
547}
548
549static void bond_opt_error_interpret(struct bonding *bond,
550				     const struct bond_option *opt,
551				     int error, const struct bond_opt_value *val)
552{
553	const struct bond_opt_value *minval, *maxval;
554	char *p;
555
556	switch (error) {
557	case -EINVAL:
558		if (val) {
559			if (val->string) {
560				/* sometimes RAWVAL opts may have new lines */
561				p = strchr(val->string, '\n');
562				if (p)
563					*p = '\0';
564				netdev_err(bond->dev, "option %s: invalid value (%s)\n",
565					   opt->name, val->string);
566			} else {
567				netdev_err(bond->dev, "option %s: invalid value (%llu)\n",
568					   opt->name, val->value);
569			}
570		}
571		minval = bond_opt_get_flags(opt, BOND_VALFLAG_MIN);
572		maxval = bond_opt_get_flags(opt, BOND_VALFLAG_MAX);
573		if (!maxval)
574			break;
575		netdev_err(bond->dev, "option %s: allowed values %llu - %llu\n",
576			   opt->name, minval ? minval->value : 0, maxval->value);
577		break;
578	case -EACCES:
579		bond_opt_dep_print(bond, opt);
580		break;
581	case -ENOTEMPTY:
582		netdev_err(bond->dev, "option %s: unable to set because the bond device has slaves\n",
583			   opt->name);
584		break;
585	case -EBUSY:
586		netdev_err(bond->dev, "option %s: unable to set because the bond device is up\n",
587			   opt->name);
588		break;
589	default:
590		break;
591	}
592}
593
594/**
595 * __bond_opt_set - set a bonding option
596 * @bond: target bond device
597 * @option: option to set
598 * @val: value to set it to
599 *
600 * This function is used to change the bond's option value, it can be
601 * used for both enabling/changing an option and for disabling it. RTNL lock
602 * must be obtained before calling this function.
603 */
604int __bond_opt_set(struct bonding *bond,
605		   unsigned int option, struct bond_opt_value *val)
606{
607	const struct bond_opt_value *retval = NULL;
608	const struct bond_option *opt;
609	int ret = -ENOENT;
610
611	ASSERT_RTNL();
612
613	opt = bond_opt_get(option);
614	if (WARN_ON(!val) || WARN_ON(!opt))
615		goto out;
616	ret = bond_opt_check_deps(bond, opt);
617	if (ret)
618		goto out;
619	retval = bond_opt_parse(opt, val);
620	if (!retval) {
621		ret = -EINVAL;
622		goto out;
623	}
624	ret = opt->set(bond, retval);
625out:
626	if (ret)
627		bond_opt_error_interpret(bond, opt, ret, val);
628	else
629		call_netdevice_notifiers(NETDEV_CHANGEINFODATA, bond->dev);
630
631	return ret;
632}
633
634/**
635 * bond_opt_tryset_rtnl - try to acquire rtnl and call __bond_opt_set
636 * @bond: target bond device
637 * @option: option to set
638 * @buf: value to set it to
639 *
640 * This function tries to acquire RTNL without blocking and if successful
641 * calls __bond_opt_set. It is mainly used for sysfs option manipulation.
642 */
643int bond_opt_tryset_rtnl(struct bonding *bond, unsigned int option, char *buf)
644{
645	struct bond_opt_value optval;
646	int ret;
647
648	if (!rtnl_trylock())
649		return restart_syscall();
650	bond_opt_initstr(&optval, buf);
651	ret = __bond_opt_set(bond, option, &optval);
652	rtnl_unlock();
653
654	return ret;
655}
656
657/**
658 * bond_opt_get - get a pointer to an option
659 * @option: option for which to return a pointer
660 *
661 * This function checks if option is valid and if so returns a pointer
662 * to its entry in the bond_opts[] option array.
663 */
664const struct bond_option *bond_opt_get(unsigned int option)
665{
666	if (!BOND_OPT_VALID(option))
667		return NULL;
668
669	return &bond_opts[option];
670}
671
672static int bond_option_mode_set(struct bonding *bond,
673				const struct bond_opt_value *newval)
674{
675	if (!bond_mode_uses_arp(newval->value) && bond->params.arp_interval) {
676		netdev_info(bond->dev, "%s mode is incompatible with arp monitoring, start mii monitoring\n",
677			    newval->string);
678		/* disable arp monitoring */
679		bond->params.arp_interval = 0;
680		/* set miimon to default value */
681		bond->params.miimon = BOND_DEFAULT_MIIMON;
682		netdev_info(bond->dev, "Setting MII monitoring interval to %d\n",
683			    bond->params.miimon);
684	}
685
686	/* don't cache arp_validate between modes */
687	bond->params.arp_validate = BOND_ARP_VALIDATE_NONE;
688	bond->params.mode = newval->value;
689
690	return 0;
691}
692
693static struct net_device *__bond_option_active_slave_get(struct bonding *bond,
694							 struct slave *slave)
695{
696	return bond_uses_primary(bond) && slave ? slave->dev : NULL;
697}
698
699struct net_device *bond_option_active_slave_get_rcu(struct bonding *bond)
700{
701	struct slave *slave = rcu_dereference(bond->curr_active_slave);
702
703	return __bond_option_active_slave_get(bond, slave);
704}
705
706static int bond_option_active_slave_set(struct bonding *bond,
707					const struct bond_opt_value *newval)
708{
709	char ifname[IFNAMSIZ] = { 0, };
710	struct net_device *slave_dev;
711	int ret = 0;
712
713	sscanf(newval->string, "%15s", ifname); /* IFNAMSIZ */
714	if (!strlen(ifname) || newval->string[0] == '\n') {
715		slave_dev = NULL;
716	} else {
717		slave_dev = __dev_get_by_name(dev_net(bond->dev), ifname);
718		if (!slave_dev)
719			return -ENODEV;
720	}
721
722	if (slave_dev) {
723		if (!netif_is_bond_slave(slave_dev)) {
724			netdev_err(bond->dev, "Device %s is not bonding slave\n",
725				   slave_dev->name);
726			return -EINVAL;
727		}
728
729		if (bond->dev != netdev_master_upper_dev_get(slave_dev)) {
730			netdev_err(bond->dev, "Device %s is not our slave\n",
731				   slave_dev->name);
732			return -EINVAL;
733		}
734	}
735
736	block_netpoll_tx();
737	/* check to see if we are clearing active */
738	if (!slave_dev) {
739		netdev_info(bond->dev, "Clearing current active slave\n");
740		RCU_INIT_POINTER(bond->curr_active_slave, NULL);
741		bond_select_active_slave(bond);
742	} else {
743		struct slave *old_active = rtnl_dereference(bond->curr_active_slave);
744		struct slave *new_active = bond_slave_get_rtnl(slave_dev);
745
746		BUG_ON(!new_active);
747
748		if (new_active == old_active) {
749			/* do nothing */
750			netdev_info(bond->dev, "%s is already the current active slave\n",
751				    new_active->dev->name);
752		} else {
753			if (old_active && (new_active->link == BOND_LINK_UP) &&
754			    bond_slave_is_up(new_active)) {
755				netdev_info(bond->dev, "Setting %s as active slave\n",
756					    new_active->dev->name);
757				bond_change_active_slave(bond, new_active);
758			} else {
759				netdev_err(bond->dev, "Could not set %s as active slave; either %s is down or the link is down\n",
760					   new_active->dev->name,
761					   new_active->dev->name);
762				ret = -EINVAL;
763			}
764		}
765	}
766	unblock_netpoll_tx();
767
768	return ret;
769}
770
771/* There are two tricky bits here.  First, if MII monitoring is activated, then
772 * we must disable ARP monitoring.  Second, if the timer isn't running, we must
773 * start it.
774 */
775static int bond_option_miimon_set(struct bonding *bond,
776				  const struct bond_opt_value *newval)
777{
778	netdev_info(bond->dev, "Setting MII monitoring interval to %llu\n",
779		    newval->value);
780	bond->params.miimon = newval->value;
781	if (bond->params.updelay)
782		netdev_info(bond->dev, "Note: Updating updelay (to %d) since it is a multiple of the miimon value\n",
783			bond->params.updelay * bond->params.miimon);
784	if (bond->params.downdelay)
785		netdev_info(bond->dev, "Note: Updating downdelay (to %d) since it is a multiple of the miimon value\n",
786			    bond->params.downdelay * bond->params.miimon);
787	if (newval->value && bond->params.arp_interval) {
788		netdev_info(bond->dev, "MII monitoring cannot be used with ARP monitoring - disabling ARP monitoring...\n");
789		bond->params.arp_interval = 0;
790		if (bond->params.arp_validate)
791			bond->params.arp_validate = BOND_ARP_VALIDATE_NONE;
792	}
793	if (bond->dev->flags & IFF_UP) {
794		/* If the interface is up, we may need to fire off
795		 * the MII timer. If the interface is down, the
796		 * timer will get fired off when the open function
797		 * is called.
798		 */
799		if (!newval->value) {
800			cancel_delayed_work_sync(&bond->mii_work);
801		} else {
802			cancel_delayed_work_sync(&bond->arp_work);
803			queue_delayed_work(bond->wq, &bond->mii_work, 0);
804		}
805	}
806
807	return 0;
808}
809
810/* Set up and down delays. These must be multiples of the
811 * MII monitoring value, and are stored internally as the multiplier.
812 * Thus, we must translate to MS for the real world.
813 */
814static int bond_option_updelay_set(struct bonding *bond,
815				   const struct bond_opt_value *newval)
816{
817	int value = newval->value;
818
819	if (!bond->params.miimon) {
820		netdev_err(bond->dev, "Unable to set up delay as MII monitoring is disabled\n");
821		return -EPERM;
822	}
823	if ((value % bond->params.miimon) != 0) {
824		netdev_warn(bond->dev, "up delay (%d) is not a multiple of miimon (%d), updelay rounded to %d ms\n",
825			    value, bond->params.miimon,
826			    (value / bond->params.miimon) *
827			    bond->params.miimon);
828	}
829	bond->params.updelay = value / bond->params.miimon;
830	netdev_info(bond->dev, "Setting up delay to %d\n",
831		    bond->params.updelay * bond->params.miimon);
832
833	return 0;
834}
835
836static int bond_option_downdelay_set(struct bonding *bond,
837				     const struct bond_opt_value *newval)
838{
839	int value = newval->value;
840
841	if (!bond->params.miimon) {
842		netdev_err(bond->dev, "Unable to set down delay as MII monitoring is disabled\n");
843		return -EPERM;
844	}
845	if ((value % bond->params.miimon) != 0) {
846		netdev_warn(bond->dev, "down delay (%d) is not a multiple of miimon (%d), delay rounded to %d ms\n",
847			    value, bond->params.miimon,
848			    (value / bond->params.miimon) *
849			    bond->params.miimon);
850	}
851	bond->params.downdelay = value / bond->params.miimon;
852	netdev_info(bond->dev, "Setting down delay to %d\n",
853		    bond->params.downdelay * bond->params.miimon);
854
855	return 0;
856}
857
858static int bond_option_use_carrier_set(struct bonding *bond,
859				       const struct bond_opt_value *newval)
860{
861	netdev_info(bond->dev, "Setting use_carrier to %llu\n",
862		    newval->value);
863	bond->params.use_carrier = newval->value;
864
865	return 0;
866}
867
868/* There are two tricky bits here.  First, if ARP monitoring is activated, then
869 * we must disable MII monitoring.  Second, if the ARP timer isn't running,
870 * we must start it.
871 */
872static int bond_option_arp_interval_set(struct bonding *bond,
873					const struct bond_opt_value *newval)
874{
875	netdev_info(bond->dev, "Setting ARP monitoring interval to %llu\n",
876		    newval->value);
877	bond->params.arp_interval = newval->value;
878	if (newval->value) {
879		if (bond->params.miimon) {
880			netdev_info(bond->dev, "ARP monitoring cannot be used with MII monitoring. Disabling MII monitoring\n");
881			bond->params.miimon = 0;
882		}
883		if (!bond->params.arp_targets[0])
884			netdev_info(bond->dev, "ARP monitoring has been set up, but no ARP targets have been specified\n");
885	}
886	if (bond->dev->flags & IFF_UP) {
887		/* If the interface is up, we may need to fire off
888		 * the ARP timer.  If the interface is down, the
889		 * timer will get fired off when the open function
890		 * is called.
891		 */
892		if (!newval->value) {
893			if (bond->params.arp_validate)
894				bond->recv_probe = NULL;
895			cancel_delayed_work_sync(&bond->arp_work);
896		} else {
897			/* arp_validate can be set only in active-backup mode */
898			bond->recv_probe = bond_arp_rcv;
899			cancel_delayed_work_sync(&bond->mii_work);
900			queue_delayed_work(bond->wq, &bond->arp_work, 0);
901		}
902	}
903
904	return 0;
905}
906
907static void _bond_options_arp_ip_target_set(struct bonding *bond, int slot,
908					    __be32 target,
909					    unsigned long last_rx)
910{
911	__be32 *targets = bond->params.arp_targets;
912	struct list_head *iter;
913	struct slave *slave;
914
915	if (slot >= 0 && slot < BOND_MAX_ARP_TARGETS) {
916		bond_for_each_slave(bond, slave, iter)
917			slave->target_last_arp_rx[slot] = last_rx;
918		targets[slot] = target;
919	}
920}
921
922static int _bond_option_arp_ip_target_add(struct bonding *bond, __be32 target)
923{
924	__be32 *targets = bond->params.arp_targets;
925	int ind;
926
927	if (!bond_is_ip_target_ok(target)) {
928		netdev_err(bond->dev, "invalid ARP target %pI4 specified for addition\n",
929			   &target);
930		return -EINVAL;
931	}
932
933	if (bond_get_targets_ip(targets, target) != -1) { /* dup */
934		netdev_err(bond->dev, "ARP target %pI4 is already present\n",
935			   &target);
936		return -EINVAL;
937	}
938
939	ind = bond_get_targets_ip(targets, 0); /* first free slot */
940	if (ind == -1) {
941		netdev_err(bond->dev, "ARP target table is full!\n");
942		return -EINVAL;
943	}
944
945	netdev_info(bond->dev, "Adding ARP target %pI4\n", &target);
946
947	_bond_options_arp_ip_target_set(bond, ind, target, jiffies);
948
949	return 0;
950}
951
952static int bond_option_arp_ip_target_add(struct bonding *bond, __be32 target)
953{
954	return _bond_option_arp_ip_target_add(bond, target);
955}
956
957static int bond_option_arp_ip_target_rem(struct bonding *bond, __be32 target)
958{
959	__be32 *targets = bond->params.arp_targets;
960	struct list_head *iter;
961	struct slave *slave;
962	unsigned long *targets_rx;
963	int ind, i;
964
965	if (!bond_is_ip_target_ok(target)) {
966		netdev_err(bond->dev, "invalid ARP target %pI4 specified for removal\n",
967			   &target);
968		return -EINVAL;
969	}
970
971	ind = bond_get_targets_ip(targets, target);
972	if (ind == -1) {
973		netdev_err(bond->dev, "unable to remove nonexistent ARP target %pI4\n",
974			   &target);
975		return -EINVAL;
976	}
977
978	if (ind == 0 && !targets[1] && bond->params.arp_interval)
979		netdev_warn(bond->dev, "Removing last arp target with arp_interval on\n");
980
981	netdev_info(bond->dev, "Removing ARP target %pI4\n", &target);
982
983	bond_for_each_slave(bond, slave, iter) {
984		targets_rx = slave->target_last_arp_rx;
985		for (i = ind; (i < BOND_MAX_ARP_TARGETS-1) && targets[i+1]; i++)
986			targets_rx[i] = targets_rx[i+1];
987		targets_rx[i] = 0;
988	}
989	for (i = ind; (i < BOND_MAX_ARP_TARGETS-1) && targets[i+1]; i++)
990		targets[i] = targets[i+1];
991	targets[i] = 0;
992
993	return 0;
994}
995
996void bond_option_arp_ip_targets_clear(struct bonding *bond)
997{
998	int i;
999
1000	for (i = 0; i < BOND_MAX_ARP_TARGETS; i++)
1001		_bond_options_arp_ip_target_set(bond, i, 0, 0);
1002}
1003
1004static int bond_option_arp_ip_targets_set(struct bonding *bond,
1005					  const struct bond_opt_value *newval)
1006{
1007	int ret = -EPERM;
1008	__be32 target;
1009
1010	if (newval->string) {
1011		if (!in4_pton(newval->string+1, -1, (u8 *)&target, -1, NULL)) {
1012			netdev_err(bond->dev, "invalid ARP target %pI4 specified\n",
1013				   &target);
1014			return ret;
1015		}
1016		if (newval->string[0] == '+')
1017			ret = bond_option_arp_ip_target_add(bond, target);
1018		else if (newval->string[0] == '-')
1019			ret = bond_option_arp_ip_target_rem(bond, target);
1020		else
1021			netdev_err(bond->dev, "no command found in arp_ip_targets file - use +<addr> or -<addr>\n");
1022	} else {
1023		target = newval->value;
1024		ret = bond_option_arp_ip_target_add(bond, target);
1025	}
1026
1027	return ret;
1028}
1029
1030static int bond_option_arp_validate_set(struct bonding *bond,
1031					const struct bond_opt_value *newval)
1032{
1033	netdev_info(bond->dev, "Setting arp_validate to %s (%llu)\n",
1034		    newval->string, newval->value);
1035
1036	if (bond->dev->flags & IFF_UP) {
1037		if (!newval->value)
1038			bond->recv_probe = NULL;
1039		else if (bond->params.arp_interval)
1040			bond->recv_probe = bond_arp_rcv;
1041	}
1042	bond->params.arp_validate = newval->value;
1043
1044	return 0;
1045}
1046
1047static int bond_option_arp_all_targets_set(struct bonding *bond,
1048					   const struct bond_opt_value *newval)
1049{
1050	netdev_info(bond->dev, "Setting arp_all_targets to %s (%llu)\n",
1051		    newval->string, newval->value);
1052	bond->params.arp_all_targets = newval->value;
1053
1054	return 0;
1055}
1056
1057static int bond_option_primary_set(struct bonding *bond,
1058				   const struct bond_opt_value *newval)
1059{
1060	char *p, *primary = newval->string;
1061	struct list_head *iter;
1062	struct slave *slave;
1063
1064	block_netpoll_tx();
1065
1066	p = strchr(primary, '\n');
1067	if (p)
1068		*p = '\0';
1069	/* check to see if we are clearing primary */
1070	if (!strlen(primary)) {
1071		netdev_info(bond->dev, "Setting primary slave to None\n");
1072		RCU_INIT_POINTER(bond->primary_slave, NULL);
1073		memset(bond->params.primary, 0, sizeof(bond->params.primary));
1074		bond_select_active_slave(bond);
1075		goto out;
1076	}
1077
1078	bond_for_each_slave(bond, slave, iter) {
1079		if (strncmp(slave->dev->name, primary, IFNAMSIZ) == 0) {
1080			netdev_info(bond->dev, "Setting %s as primary slave\n",
1081				    slave->dev->name);
1082			rcu_assign_pointer(bond->primary_slave, slave);
1083			strcpy(bond->params.primary, slave->dev->name);
1084			bond_select_active_slave(bond);
1085			goto out;
1086		}
1087	}
1088
1089	if (rtnl_dereference(bond->primary_slave)) {
1090		netdev_info(bond->dev, "Setting primary slave to None\n");
1091		RCU_INIT_POINTER(bond->primary_slave, NULL);
1092		bond_select_active_slave(bond);
1093	}
1094	strncpy(bond->params.primary, primary, IFNAMSIZ);
1095	bond->params.primary[IFNAMSIZ - 1] = 0;
1096
1097	netdev_info(bond->dev, "Recording %s as primary, but it has not been enslaved to %s yet\n",
1098		    primary, bond->dev->name);
1099
1100out:
1101	unblock_netpoll_tx();
1102
1103	return 0;
1104}
1105
1106static int bond_option_primary_reselect_set(struct bonding *bond,
1107					    const struct bond_opt_value *newval)
1108{
1109	netdev_info(bond->dev, "Setting primary_reselect to %s (%llu)\n",
1110		    newval->string, newval->value);
1111	bond->params.primary_reselect = newval->value;
1112
1113	block_netpoll_tx();
1114	bond_select_active_slave(bond);
1115	unblock_netpoll_tx();
1116
1117	return 0;
1118}
1119
1120static int bond_option_fail_over_mac_set(struct bonding *bond,
1121					 const struct bond_opt_value *newval)
1122{
1123	netdev_info(bond->dev, "Setting fail_over_mac to %s (%llu)\n",
1124		    newval->string, newval->value);
1125	bond->params.fail_over_mac = newval->value;
1126
1127	return 0;
1128}
1129
1130static int bond_option_xmit_hash_policy_set(struct bonding *bond,
1131					    const struct bond_opt_value *newval)
1132{
1133	netdev_info(bond->dev, "Setting xmit hash policy to %s (%llu)\n",
1134		    newval->string, newval->value);
1135	bond->params.xmit_policy = newval->value;
1136
1137	return 0;
1138}
1139
1140static int bond_option_resend_igmp_set(struct bonding *bond,
1141				       const struct bond_opt_value *newval)
1142{
1143	netdev_info(bond->dev, "Setting resend_igmp to %llu\n",
1144		    newval->value);
1145	bond->params.resend_igmp = newval->value;
1146
1147	return 0;
1148}
1149
1150static int bond_option_num_peer_notif_set(struct bonding *bond,
1151				   const struct bond_opt_value *newval)
1152{
1153	bond->params.num_peer_notif = newval->value;
1154
1155	return 0;
1156}
1157
1158static int bond_option_all_slaves_active_set(struct bonding *bond,
1159					     const struct bond_opt_value *newval)
1160{
1161	struct list_head *iter;
1162	struct slave *slave;
1163
1164	if (newval->value == bond->params.all_slaves_active)
1165		return 0;
1166	bond->params.all_slaves_active = newval->value;
1167	bond_for_each_slave(bond, slave, iter) {
1168		if (!bond_is_active_slave(slave)) {
1169			if (newval->value)
1170				slave->inactive = 0;
1171			else
1172				slave->inactive = 1;
1173		}
1174	}
1175
1176	return 0;
1177}
1178
1179static int bond_option_min_links_set(struct bonding *bond,
1180				     const struct bond_opt_value *newval)
1181{
1182	netdev_info(bond->dev, "Setting min links value to %llu\n",
1183		    newval->value);
1184	bond->params.min_links = newval->value;
1185
1186	return 0;
1187}
1188
1189static int bond_option_lp_interval_set(struct bonding *bond,
1190				       const struct bond_opt_value *newval)
1191{
1192	bond->params.lp_interval = newval->value;
1193
1194	return 0;
1195}
1196
1197static int bond_option_pps_set(struct bonding *bond,
1198			       const struct bond_opt_value *newval)
1199{
1200	bond->params.packets_per_slave = newval->value;
1201	if (newval->value > 0) {
1202		bond->params.reciprocal_packets_per_slave =
1203			reciprocal_value(newval->value);
1204	} else {
1205		/* reciprocal_packets_per_slave is unused if
1206		 * packets_per_slave is 0 or 1, just initialize it
1207		 */
1208		bond->params.reciprocal_packets_per_slave =
1209			(struct reciprocal_value) { 0 };
1210	}
1211
1212	return 0;
1213}
1214
1215static int bond_option_lacp_rate_set(struct bonding *bond,
1216				     const struct bond_opt_value *newval)
1217{
1218	netdev_info(bond->dev, "Setting LACP rate to %s (%llu)\n",
1219		    newval->string, newval->value);
1220	bond->params.lacp_fast = newval->value;
1221	bond_3ad_update_lacp_rate(bond);
1222
1223	return 0;
1224}
1225
1226static int bond_option_ad_select_set(struct bonding *bond,
1227				     const struct bond_opt_value *newval)
1228{
1229	netdev_info(bond->dev, "Setting ad_select to %s (%llu)\n",
1230		    newval->string, newval->value);
1231	bond->params.ad_select = newval->value;
1232
1233	return 0;
1234}
1235
1236static int bond_option_queue_id_set(struct bonding *bond,
1237				    const struct bond_opt_value *newval)
1238{
1239	struct slave *slave, *update_slave;
1240	struct net_device *sdev;
1241	struct list_head *iter;
1242	char *delim;
1243	int ret = 0;
1244	u16 qid;
1245
1246	/* delim will point to queue id if successful */
1247	delim = strchr(newval->string, ':');
1248	if (!delim)
1249		goto err_no_cmd;
1250
1251	/* Terminate string that points to device name and bump it
1252	 * up one, so we can read the queue id there.
1253	 */
1254	*delim = '\0';
1255	if (sscanf(++delim, "%hd\n", &qid) != 1)
1256		goto err_no_cmd;
1257
1258	/* Check buffer length, valid ifname and queue id */
1259	if (!dev_valid_name(newval->string) ||
1260	    qid > bond->dev->real_num_tx_queues)
1261		goto err_no_cmd;
1262
1263	/* Get the pointer to that interface if it exists */
1264	sdev = __dev_get_by_name(dev_net(bond->dev), newval->string);
1265	if (!sdev)
1266		goto err_no_cmd;
1267
1268	/* Search for thes slave and check for duplicate qids */
1269	update_slave = NULL;
1270	bond_for_each_slave(bond, slave, iter) {
1271		if (sdev == slave->dev)
1272			/* We don't need to check the matching
1273			 * slave for dups, since we're overwriting it
1274			 */
1275			update_slave = slave;
1276		else if (qid && qid == slave->queue_id) {
1277			goto err_no_cmd;
1278		}
1279	}
1280
1281	if (!update_slave)
1282		goto err_no_cmd;
1283
1284	/* Actually set the qids for the slave */
1285	update_slave->queue_id = qid;
1286
1287out:
1288	return ret;
1289
1290err_no_cmd:
1291	netdev_info(bond->dev, "invalid input for queue_id set\n");
1292	ret = -EPERM;
1293	goto out;
1294
1295}
1296
1297static int bond_option_slaves_set(struct bonding *bond,
1298				  const struct bond_opt_value *newval)
1299{
1300	char command[IFNAMSIZ + 1] = { 0, };
1301	struct net_device *dev;
1302	char *ifname;
1303	int ret;
1304
1305	sscanf(newval->string, "%16s", command); /* IFNAMSIZ*/
1306	ifname = command + 1;
1307	if ((strlen(command) <= 1) ||
1308	    !dev_valid_name(ifname))
1309		goto err_no_cmd;
1310
1311	dev = __dev_get_by_name(dev_net(bond->dev), ifname);
1312	if (!dev) {
1313		netdev_info(bond->dev, "interface %s does not exist!\n",
1314			    ifname);
1315		ret = -ENODEV;
1316		goto out;
1317	}
1318
1319	switch (command[0]) {
1320	case '+':
1321		netdev_info(bond->dev, "Adding slave %s\n", dev->name);
1322		ret = bond_enslave(bond->dev, dev);
1323		break;
1324
1325	case '-':
1326		netdev_info(bond->dev, "Removing slave %s\n", dev->name);
1327		ret = bond_release(bond->dev, dev);
1328		break;
1329
1330	default:
1331		goto err_no_cmd;
1332	}
1333
1334out:
1335	return ret;
1336
1337err_no_cmd:
1338	netdev_err(bond->dev, "no command found in slaves file - use +ifname or -ifname\n");
1339	ret = -EPERM;
1340	goto out;
1341}
1342
1343static int bond_option_tlb_dynamic_lb_set(struct bonding *bond,
1344					  const struct bond_opt_value *newval)
1345{
1346	netdev_info(bond->dev, "Setting dynamic-lb to %s (%llu)\n",
1347		    newval->string, newval->value);
1348	bond->params.tlb_dynamic_lb = newval->value;
1349
1350	return 0;
1351}
1352