| d93fc78f47f93a25a9f99fea613616901331d213 |
|
23-Apr-2014 |
Jingoo Han <jg1.han@samsung.com> |
pwm: pxa: Remove unnecessary OOM messages
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
|
| 2ae69a460413615c82381b240df3800a909100d3 |
|
01-Apr-2014 |
Thierry Reding <thierry.reding@gmail.com> |
pwm: pxa: Constify OF match table
The table is never modified and all OF functions that use it take a
const struct of_device_id *.
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
|
| fdec4f72719dbd6fc74776630b06ad851f4c2d81 |
|
01-Apr-2014 |
Thierry Reding <thierry.reding@gmail.com> |
pwm: pxa: Fix typo "pwm" -> "PWM"
Being an abbreviation, PWM should always be capitalized in prose.
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
|
| f409cd38334ce4d2b1b99fef00543de1695a281f |
|
01-Apr-2014 |
Thierry Reding <thierry.reding@gmail.com> |
Revert "pwm: pxa: Use of_match_ptr()"
This reverts commit 8468949cddcdbb1b1b1bc552aefceb252078ceb1.
The OF match table dummy for non-OF configurations cannot be removed
because it is still used by the pxa_pwm_get_id_dt() function.
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
|
| 8468949cddcdbb1b1b1bc552aefceb252078ceb1 |
|
26-Feb-2014 |
Jingoo Han <jg1.han@samsung.com> |
pwm: pxa: Use of_match_ptr()
Use of_match_ptr(), because of_match_ptr() returns NULL pointer
when CONFIG_OF is disabled.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
|
| b07ab66391e47aacca9309eb88edef4897d94c77 |
|
19-Dec-2013 |
Jingoo Han <jg1.han@samsung.com> |
pwm: pxa: remove unnecessary space before tabs
Remove unnecessary space before tabs in order to fix the following
checkpatch warning.
WARNING: please, no space before tabs
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
|
| b52fa7bc5dc9697fb5983727d276dd565d85a8d0 |
|
21-Sep-2013 |
Mike Dunn <mikedunn@newsguy.com> |
pwm: pxa: Add device tree support
This patch adds device tree support to the PXA's PWM driver. Nothing
needs to be extracted from the device tree node by the PWM device.
Client devices need only specify the period; the per-chip index is
implicitly zero because one device node must be present for each PWM
output in use. This approach is more convenient due to the wide
variability in the number of PWM channels present across the various PXA
variants, and is made possible by the fact that the register sets for
each PWM channel are segregated from each other. An of_xlate() method
is added to parse this single-cell node. The existing ID table is
reused for the match table data.
Tested on a Palm Treo 680 (both platform data and DT cases).
Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
|
| 1e185c7aafbb56580feaa5bdbc9e4b1d8efaf710 |
|
08-Aug-2013 |
Mike Dunn <mikedunn@newsguy.com> |
pwm: pxa: Use module_platform_driver
Commit 76abbdde2d95a3807d0dc6bf9f84d03d0dbd4f3d
pwm: Add sysfs interface
causes a kernel oops due to a null pointer dereference on PXA platforms.
This happens because the class added by the patch is registered in a
subsys_initcall (initcall4), but the pxa pwm driver is registered in
arch_initcall (initcall3). If the class is not registered before the
driver probe function runs, the oops occurs in device_add() when the
uninitialized pointers in struct class are dereferenced. I don't see a
reason that the driver must be an arch_initcall, so this patch makes it
a regular module_platform_driver (initcall6), preventing the oops.
Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Acked-by: Marek Vasut <marex@denx.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
|
| 362e9cd2f54e3c72a37ff8e3319366554e48c555 |
|
12-May-2013 |
Wolfram Sang <wsa@the-dreams.de> |
drivers/pwm: don't check resource with devm_ioremap_resource
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Acked-by: Stephen Warren <swarren@nvidia.com>
|
| 22976a5dada65a0f44918e91c5f1fb5041dc1d5e |
|
01-Apr-2013 |
Axel Lin <axel.lin@ingics.com> |
pwm: pxa: Remove PWM_ID_BASE macro
PWM_ID_BASE() is not used after convert to PWM framework, remove it.
Also update driver_data field of struct platform_device_id accordingly.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Eric Miao <eric.y.miao@gmail.com>
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
|
| b014a30c5991e67aa90b6ff9bd4ec16435bbcefd |
|
31-Mar-2013 |
Axel Lin <axel.lin@ingics.com> |
pwm: pxa: Remove clk_enabled field from struct pxa_pwm_chip
clk_enable/clk_disable maintain an enable_count, clk_prepare and clk_unprepare
also maintain a prepare_count. These APIs will do prepare/enable when the first
user calling these APIs, and do disable/unprepare when the corresponding counter
reach 0. Thus We don't need to maintain a clk_enabled counter here.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Eric Miao <eric.y.miao@gmail.com>
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
|
| 6d4294d1634543853febc4287ecf02998fd234e1 |
|
21-Jan-2013 |
Thierry Reding <thierry.reding@avionic-design.de> |
pwm: Convert to devm_ioremap_resource()
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 77f37917a6f2bd8635b553178bb34bdd80f08e40 |
|
19-Nov-2012 |
Bill Pemberton <wfp5p@virginia.edu> |
pwm: remove use of __devexit
CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Acked-by: Thierry Reding <thierry.reding@avionic-design.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 3e9fe83d278cce6974f0a4d1870c0ff4a0b74ba5 |
|
19-Nov-2012 |
Bill Pemberton <wfp5p@virginia.edu> |
pwm: remove use of __devinit
CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Acked-by: Thierry Reding <thierry.reding@avionic-design.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| fd1091125a1d11fcc635749d0d3dec36904a7a48 |
|
19-Nov-2012 |
Bill Pemberton <wfp5p@virginia.edu> |
pwm: remove use of __devexit_p
CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Acked-by: Thierry Reding <thierry.reding@avionic-design.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| c2d476a98f71c55e9acdca1d5a1080a22c0622af |
|
02-Sep-2012 |
Thierry Reding <thierry.reding@avionic-design.de> |
pwm: Check for negative duty-cycle and period
Make sure the duty-cycle and period passed in are not negative. This
should eventually be made implicit by making them unsigned. While at
it, the drivers' .config() implementations can have the equivalent
checks removed.
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Axel Lin <axel.lin@gmail.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>
Cc: Jingoo Han <jg1.han@samsung.com>
Cc: Jonghwan Choi <jhbird.choi@samsung.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: "Philip, Avinash" <avinashphilip@ti.com>
Cc: Vaibhav Bedia <vaibhav.bedia@ti.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
|
| abeaf75527386adea831914579f0b8711287d3f8 |
|
02-Jul-2012 |
Thierry Reding <thierry.reding@avionic-design.de> |
pwm: pxa: Propagate pwmchip_remove() error
If the pwmchip_remove() call fails, propagate the error to the driver's
remove callback. This is required to prevent the module from being
unloaded if a PWM provided by the driver is still in use.
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
|
| 45b301d2b188af6db332cbb14c36e20b5204223e |
|
01-Jul-2012 |
Axel Lin <axel.lin@gmail.com> |
pwm: Convert pwm-pxa to use devm_* APIs
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
|
| 17b2b4780f879a559b8dc96c170dd6df98fe9ab3 |
|
02-Jan-2012 |
Thierry Reding <thierry.reding@avionic-design.de> |
pwm: Move PXA PWM driver to PWM framework
This commit moves the PXA PWM driver to the drivers/pwm subdirectory and
converts it to use the new PWM framework.
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
|