[go: nahoru, domu]

Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 164304: Http cache: Extend support for byte range requests.... (Closed)

Created:
11 years, 4 months ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium
Visibility:
Public.

Description

Http cache: Extend support for byte range requests. * Now we handle regular requests (not byte range requests) that end up reading a cached entry that stores byte ranges. In this case we create a control object (partial_), but it's byte_range_ member is always invalid because the user is not requesting a range. * Given that we may find stored 206s that are not keeping sparse data, we detect that case and handle it. * Now we may end up reading 206 from disk (and the net) and having to change the returned status to be 200 (for regular requests). * We avoid performing re-validations for each piece of stored data. Instead, we consider the whole entry to be revalidated once, and read from the cache without asking the server (as far as we can). * When processing the received headers we now consider receiving 200 and 416 (instead of 206/304) and we handle inconsistencies in the range returned by the server (from what we expect). We also handle receiving 206 when we don't expect it. BUG=12258 TEST=unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23123

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -48 lines) Patch
M net/http/http_cache.cc View 9 chunks +85 lines, -21 lines 0 comments Download
M net/http/http_cache_unittest.cc View 1 9 chunks +183 lines, -9 lines 0 comments Download
M net/http/http_response_headers.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_response_headers.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M net/http/http_response_headers_unittest.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M net/http/partial_data.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/partial_data.cc View 5 chunks +36 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rvargas (doing something else)
11 years, 4 months ago (2009-08-11 02:29:54 UTC) #1
darin (slow to review)
11 years, 4 months ago (2009-08-11 21:15:09 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698