Issue 3549018: Fixed crash when GetClientRect fails....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3549018: Fixed crash when GetClientRect fails.... (Closed)

Created:
10 years, 2 months ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixed crash when GetClientRect fails. There is a known race condition with windows being destroyed while the GPU process has a live handle to them. This change treats destroyed windows as having size zero rather than crashing. TEST=try BUG=58065 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61702

Patch Set 1 #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	app/gfx/gl/gl_context_egl.cc	View		1 chunk	+5 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

LGTM http://codereview.chromium.org/3549018/diff/1/2 File app/gfx/gl/gl_context_egl.cc (right): http://codereview.chromium.org/3549018/diff/1/2#newcode183 app/gfx/gl/gl_context_egl.cc:183: DCHECK(false) << "GetClientRect failed."; Given this fix, do ...

10 years, 2 months ago (2010-10-06 17:53:49 UTC) #2

apatrick

10 years, 2 months ago (2010-10-06 17:57:58 UTC) #3

On Wed, Oct 6, 2010 at 10:53 AM, <kbr@chromium.org> wrote:

> LGTM
>
>
>
> http://codereview.chromium.org/3549018/diff/1/2
> File app/gfx/gl/gl_context_egl.cc (right):
>
> http://codereview.chromium.org/3549018/diff/1/2#newcode183
> app/gfx/gl/gl_context_egl.cc:183: DCHECK(false) << "GetClientRect
> failed.";
> Given this fix, do you still want to assert in debug builds?
>
>
> http://codereview.chromium.org/3549018/show
>

Yes, it's a legitimate bug. I don't want to hide it.

Expand Messages | Collapse Messages