Issue 3620005: Follow up to wtc comments on http://codereview.chromium.org/3571011

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3620005: Follow up to wtc comments on http://codereview.chromium.org/3571011 (Closed)

Created:
10 years, 2 months ago by joth

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, bulach

Visibility:
Public.

Description

Follow up to wtc comments on http://codereview.chromium.org/3571011 Removes unneeded OpenSSL error handling, and add some logging to aid further development BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61647

Patch Set 1 #

Total comments: 1

Patch Set 2 : wtc comments on patch set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -17 lines)			Patch
	M	net/socket/ssl_client_socket_openssl.cc	View	1	4 chunks	+15 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

10 years, 2 months ago (2010-10-05 17:51:24 UTC) #2

LGTM.

http://codereview.chromium.org/3620005/diff/1/2
File net/socket/ssl_client_socket_openssl.cc (right):

http://codereview.chromium.org/3620005/diff/1/2#newcode572
net/socket/ssl_client_socket_openssl.cc:572: DVLOG(1) << "TransportReadComplete
error " << result;
Nit: If 'result' is 0, it's not really an error code.

The comment on the next line says "Received end of file",
but that's true only if 'result' is 0.  Can 'result' be
negative here?

Expand Messages | Collapse Messages