[go: nahoru, domu]
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3743001: FBTF: Fix more ctor/dtors found by clang plugin. (Closed)

Created:
10 years, 2 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, vrk (LEFT CHROMIUM), fbarchard, ben+cc_chromium.org, Erik does not do reviews, Alpha Left Google, apatrick_chromium, Aaron Boodman, pam+watch_chromium.org, awong, brettw-cc_chromium.org, darin-cc_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

FBTF: Fix more ctor/dtors found by clang plugin. (1.2 megs off of Debug Linux .a files) BUG=none TEST=compiles everywhere Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62420

Patch Set 1 #

Patch Set 2 : Rebase to pick up mac fix on ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -88 lines) Patch
M base/process_util.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M base/process_util.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M base/thread_checker.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/thread_checker.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/default_apps.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/default_apps.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/shell_dialogs.h View 3 chunks +7 lines, -4 lines 0 comments Download
A chrome/browser/shell_dialogs.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view.h View 3 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/webmessageportchannel_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/webmessageportchannel_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/profile_import/profile_import_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/profile_import/profile_import_thread.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/fenced_allocator.h View 1 chunk +1 line, -5 lines 0 comments Download
M gpu/command_buffer/client/fenced_allocator.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/mapped_memory.h View 1 chunk +1 line, -3 lines 0 comments Download
M gpu/command_buffer/client/mapped_memory.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/id_allocator.h View 1 chunk +5 lines, -15 lines 0 comments Download
M gpu/command_buffer/common/id_allocator.cc View 2 chunks +29 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.h View 3 chunks +3 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/common_decoder.h View 2 chunks +4 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/common_decoder.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.h View 3 chunks +3 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/id_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/id_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 4 chunks +6 lines, -13 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/shader_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/shader_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/filters.h View 2 chunks +7 lines, -0 lines 0 comments Download
M media/base/filters.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M webkit/glue/media/video_renderer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/media/video_renderer_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
10 years, 2 months ago (2010-10-13 00:37:53 UTC) #1
James Hawkins
10 years, 2 months ago (2010-10-13 00:40:43 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698