net/ftp/ftp_directory_listing_parsers_unittest.cc - Issue 339059: Add compiler-specific "examine printf format" attributes to printfs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ftp/ftp_directory_listing_parsers_unittest.cc

Issue 339059: Add compiler-specific "examine printf format" attributes to printfs. (Closed)

Patch Set: cleanups Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/ftp/ftp_directory_listing_parsers_unittest.cc

diff --git a/net/ftp/ftp_directory_listing_parsers_unittest.cc b/net/ftp/ftp_directory_listing_parsers_unittest.cc

index 8c9709143120bfbbe6579e9595c07f1665bdd6ff..19c6feb5bc2f91b66c74ee58966468a8b8289cc1 100644

--- a/net/ftp/ftp_directory_listing_parsers_unittest.cc

+++ b/net/ftp/ftp_directory_listing_parsers_unittest.cc

@@ -4,6 +4,7 @@

#include "net/ftp/ftp_directory_listing_parsers.h"

+#include "base/format_macros.h"

#include "base/string_util.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -69,7 +70,7 @@ TEST_F(FtpDirectoryListingParsersTest, Ls) {

now_exploded.year, 10, 12, 13, 37 },

};

for (size_t i = 0; i < arraysize(good_cases); i++) {

- SCOPED_TRACE(StringPrintf("Test[%d]: %s", i, good_cases[i].input));

+ SCOPED_TRACE(StringPrintf("Test[%" PRIuS "]: %s", i, good_cases[i].input));

net::FtpLsDirectoryListingParser parser;

RunSingleLineTestCase(&parser, good_cases[i]);

@@ -128,7 +129,7 @@ TEST_F(FtpDirectoryListingParsersTest, Windows) {

1979, 1, 6, 2, 42 },

};

for (size_t i = 0; i < arraysize(good_cases); i++) {

- SCOPED_TRACE(StringPrintf("Test[%d]: %s", i, good_cases[i].input));

+ SCOPED_TRACE(StringPrintf("Test[%" PRIuS "]: %s", i, good_cases[i].input));

net::FtpWindowsDirectoryListingParser parser;

RunSingleLineTestCase(&parser, good_cases[i]);

@@ -180,7 +181,7 @@ TEST_F(FtpDirectoryListingParsersTest, Vms) {

2005, 3, 12, 8, 44 },

};

for (size_t i = 0; i < arraysize(good_cases); i++) {

- SCOPED_TRACE(StringPrintf("Test[%d]: %s", i, good_cases[i].input));

+ SCOPED_TRACE(StringPrintf("Test[%" PRIuS "]: %s", i, good_cases[i].input));

net::FtpVmsDirectoryListingParser parser;

ASSERT_TRUE(

@@ -234,7 +235,7 @@ TEST_F(FtpDirectoryListingParsersTest, Vms) {

"Directory ROOT|X.TXT;2 1 12-MAR-2005 08:44:57 [X] (RWED,RRWWEEDD,RE,RE)",

};

for (size_t i = 0; i < arraysize(bad_cases); i++) {

- SCOPED_TRACE(StringPrintf("Test[%d]: %s", i, bad_cases[i]));

+ SCOPED_TRACE(StringPrintf("Test[%" PRIuS "]: %s", i, bad_cases[i]));

std::vector<std::string> lines;

SplitString(bad_cases[i], '|', &lines);

« net/disk_cache/sparse_control.cc ('K') | « net/ftp/ftp_directory_listing_buffer_unittest.cc ('k') | net/http/http_cache.cc » ('j') | net/http/http_network_transaction.cc » ('J')