[go: nahoru, domu]

Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 504068: Revert 34994, maybe it regressed startup perf - Fix cpu/memory measurements o... (Closed)

Created:
11 years ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, Paul Godavari, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review)
Visibility:
Public.

Description

Revert 34994, maybe it regressed startup perf - Fix cpu/memory measurements on OS X. Right now, this only works for the current process; support for child processes will be added in a later CL. BUG=13156, 25454 TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes. Review URL: http://codereview.chromium.org/500118 TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -212 lines) Patch
M base/process_util.h View 4 chunks +0 lines, -32 lines 0 comments Download
M base/process_util_mac.mm View 2 chunks +7 lines, -118 lines 0 comments Download
M base/process_util_posix.cc View 2 chunks +47 lines, -20 lines 0 comments Download
M base/trace_event.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/task_manager.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M chrome/common/mach_ipc_mac.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/common/mach_ipc_mac.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/chrome_process_util.h View 1 chunk +1 line, -6 lines 0 comments Download
M webkit/glue/webkitclient_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
11 years ago (2009-12-19 01:30:50 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698