Issue 6597075: FilePath: add a convertor to ASCII

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6597075: FilePath: add a convertor to ASCII (Closed)

Created:
9 years, 9 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Avi (use Gerrit)

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, jshin+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

FilePath: add a convertor to ASCII This is needed for cases where we need to work with known-ASCII filenames, like locale paths. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76426

Patch Set 1 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -6 lines)			Patch
M	base/file_path.h	View	1 chunk	+5 lines, -0 lines	1 comment	Download
M	base/file_path.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/spellcheck_host.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/extension_l10n_util.cc	View	1 chunk	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

9 years, 9 months ago (2011-03-01 19:56:36 UTC) #3

http://codereview.chromium.org/6597075/diff/1/base/file_path.h
File base/file_path.h (right):

http://codereview.chromium.org/6597075/diff/1/base/file_path.h#newcode289
base/file_path.h:289: std::string MaybeAsASCII() const;
method name FTW

Expand Messages | Collapse Messages