Hello Mark,

Review the following patchset please.

http://codereview.chromium.org/8773051/diff/1/base/process_util_freebsd.cc
File base/process_util_freebsd.cc (right):

http://codereview.chromium.org/8773051/diff/1/base/process_util_freebsd.cc#ne...
base/process_util_freebsd.cc:49: || length == 0)
|| goes on the preceding line.

http://codereview.chromium.org/8773051/diff/1/base/process_util_freebsd.cc#ne...
base/process_util_freebsd.cc:56: : index_of_kinfo_proc_(),
This needs more indentation.

http://codereview.chromium.org/8773051/diff/1/base/process_util_freebsd.cc#ne...
base/process_util_freebsd.cc:57: filter_(filter) {
And this should be lined up under the 'i' in index above.

http://codereview.chromium.org/8773051/diff/1/base/process_util_freebsd.cc
File base/process_util_freebsd.cc (right):

http://codereview.chromium.org/8773051/diff/1/base/process_util_freebsd.cc#ne...
base/process_util_freebsd.cc:49: || length == 0)
On 2011/12/02 20:58:06, Mark Mentovai wrote:
> || goes on the preceding line.

Done.

http://codereview.chromium.org/8773051/diff/1/base/process_util_freebsd.cc#ne...
base/process_util_freebsd.cc:56: : index_of_kinfo_proc_(),
On 2011/12/02 20:58:06, Mark Mentovai wrote:
> This needs more indentation.

Done.

http://codereview.chromium.org/8773051/diff/1/base/process_util_freebsd.cc#ne...
base/process_util_freebsd.cc:57: filter_(filter) {
On 2011/12/02 20:58:06, Mark Mentovai wrote:
> And this should be lined up under the 'i' in index above.

Done.

LG otherwise.

http://codereview.chromium.org/8773051/diff/4001/base/process_util_freebsd.cc
File base/process_util_freebsd.cc (right):

http://codereview.chromium.org/8773051/diff/4001/base/process_util_freebsd.cc...
base/process_util_freebsd.cc:49: length == 0)
Style nit: you need {braces} because the condition eats up more than one line.

http://codereview.chromium.org/8773051/diff/4001/base/process_util_freebsd.cc...
base/process_util_freebsd.cc:146: entry_.exe_file_.assign(data, last_slash + 1,
You need {braces} because the controlled statement eats up more than one line.
Once you add braces here, you’ll need them on the if clause as well.

http://codereview.chromium.org/8773051/diff/4001/base/process_util_freebsd.cc...
base/process_util_freebsd.cc:269: NULL, 0) < 0)
{} again.

http://codereview.chromium.org/8773051/diff/4001/base/process_util_freebsd.cc
File base/process_util_freebsd.cc (right):

http://codereview.chromium.org/8773051/diff/4001/base/process_util_freebsd.cc...
base/process_util_freebsd.cc:49: length == 0)
On 2011/12/03 16:43:52, Mark Mentovai wrote:
> Style nit: you need {braces} because the condition eats up more than one line.

Done.

http://codereview.chromium.org/8773051/diff/4001/base/process_util_freebsd.cc...
base/process_util_freebsd.cc:146: entry_.exe_file_.assign(data, last_slash + 1,
On 2011/12/03 16:43:52, Mark Mentovai wrote:
> You need {braces} because the controlled statement eats up more than one line.
> Once you add braces here, you’ll need them on the if clause as well.

Done.

http://codereview.chromium.org/8773051/diff/4001/base/process_util_freebsd.cc...
base/process_util_freebsd.cc:269: NULL, 0) < 0)
On 2011/12/03 16:43:52, Mark Mentovai wrote:
> {} again.

Done.

http://codereview.chromium.org/8773051/diff/7001/base/process_util_freebsd.cc
File base/process_util_freebsd.cc (right):

http://codereview.chromium.org/8773051/diff/7001/base/process_util_freebsd.cc...
base/process_util_freebsd.cc:293: } // namespace base
One more stupid one: two spaces before the // in an in-line comment like this.

http://codereview.chromium.org/8773051/diff/7001/base/process_util_freebsd.cc
File base/process_util_freebsd.cc (right):

http://codereview.chromium.org/8773051/diff/7001/base/process_util_freebsd.cc...
base/process_util_freebsd.cc:293: } // namespace base
On 2011/12/03 17:29:00, Mark Mentovai wrote:
> One more stupid one: two spaces before the // in an in-line comment like this.

Done.

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8773051/5009

Try job failure for 8773051-5009 (retry) on mac_rel for steps "browser_tests,
ui_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8773051/5009

Change committed as 112936