| commit | 58ef0380e0f989b7532babbff23bcef0d3ba64b6 | [log] [tgz] |
|---|---|---|
| author | Melba Nuzen <mnuzen@google.com> | Thu Oct 27 16:35:09 2022 -0700 |
| committer | Melba Nuzen <mnuzen@google.com> | Tue Nov 08 16:14:30 2022 -0800 |
| tree | 243f0fbf4a0b0bf5475b1b177bfc07462904a039 | |
| parent | 27fd456d4264d01fa68c19130c22d30e3557783e [diff] |
Internal change from using SemanticsSort to 'setTraversal' This change is meant to be pre-work for a larger refactoring of focus order in Compose and shouldn’t introduce any changes in A11y behavior. Issues seen in b/227206751 and https://github.com/maxim-pandra/ComplexAccessibility are part of an problem where parent/child relations in existing Semantics nodes block some ways of ordering—for example, if there were a row containing multiple text elements, then a following button overlaid on the row, TalkBack would read through all text elements before jumping back up the screen to the button. This is because `SemanticsSort` will always read the children of a parent node before moving on. A comparison independent of parent/child hierarchies would read the text children up to where the button element is on the screen, read the button element, and then proceed with the rest of the text children. This patch is just meant to check that we can use `setTraversalBefore` to determine our own custom order for semantics nodes (overriding the existing hierarchies). `setTraversalValues` in `AndroidComposeViewAccessibilityDelegateCompat` should order semantics nodes in the same way `SemanticsSort` did, except by setting the `traversalBefore` value for each node that will be read by TalkBack. This ordering is set in a mapping when semantic nodes are first retrieved. Then when a nodeInfo is created, the code now looks up our custom traversal order and uses `setTraversalBefore` on that ANI. That way, when TalkBack goes through the ANI tree, it’ll use the `traversalBefore` parameter and traverse in the way that we want regardless, of parent/child hierarchies. Bug: 186443263 Test: compose/ui/AndroidAccessibilityTest/testCreateAccessibilityNodeInfo_forTraversalOrder Change-Id: I339010bea62afb359e63d6e63889acff2c72cf27
Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.
Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.
Our official AARs and JARs binaries are distributed through Google Maven.
You can learn more about using it from Android Jetpack landing page.
For contributions via GitHub, see the GitHub Contribution Guide.
Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:
When contributing to Jetpack, follow the code review etiquette.
We are not currently accepting new modules.
Head over to the onboarding docs to learn more about getting set up and the development workflow!
Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.
Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:
Generate a HTTPS password: https://android-review.googlesource.com/new-password
Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement
AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), jcenter(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.