commit | f1466605c3cf02f2efac2ca8718f01459ab1c0f6 | [log] [tgz] |
---|---|---|
author | Jack He <siyuanh@google.com> | Thu May 24 15:53:27 2018 -0700 |
committer | Jack He <siyuanh@google.com> | Fri May 25 23:37:08 2018 +0000 |
tree | aa5890cdf681d475f7143114023a7c2b5588cc76 | |
parent | c9a04d0a3eff7b583754265e854bf72fff3cf273 [diff] |
HFP: Only advance BTIF queue for outgoing connections * Modify HFP btif layer to only advance queue when there is a connection outcome for outgoing connections * During an ACL collision, incoming connection may preempt outgoing connection and come back to the upper layer in a separate control block. In this case, we should not advance the btif queue until the outgoing connection sends callback to the btif layer * When RFCOMM connection is successful, but SLC connection failed, we should also send callback to Java layer and advance the queue. We should only do this when transition from RFCOMM connected to Disconnected, not from SLC connected to Disconnected * We should only advance the queue after sending connection state update to Java layer * This prevents the crash in connect_int() where we check for any control block that is left in connecting state Bug: 80251999 Test: connect HFP devices rapidly to trigger ACL collision testplans/details/166812/3975 Change-Id: Iba3736c77d8ef4a4701896461042466c26bc4820 (cherry picked from commit 8ced3dfacba328b1260096b93b9e9e6f65929fe3)
Just build AOSP - Fluoride is there by default.
Instructions for Ubuntu, tested on 14.04 with Clang 3.5.0 and 16.10 with Clang 3.8.0
mkdir ~/fluoride cd ~/fluoride git clone https://android.googlesource.com/platform/system/bt
Install dependencies (require sudo access):
cd ~/fluoride/bt build/install_deps.sh
Then fetch third party dependencies:
cd ~/fluoride/bt mkdir third_party cd third_party git clone https://github.com/google/googletest.git git clone https://android.googlesource.com/platform/external/aac git clone https://android.googlesource.com/platform/external/libchrome git clone https://android.googlesource.com/platform/external/libldac git clone https://android.googlesource.com/platform/external/modp_b64 git clone https://android.googlesource.com/platform/external/tinyxml2
And third party dependencies of third party dependencies:
cd fluoride/bt/third_party/libchrome/base/third_party mkdir valgrind cd valgrind curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/valgrind.h?format=TEXT | base64 -d > valgrind.h curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/memcheck.h?format=TEXT | base64 -d > memcheck.h
NOTE: If system/bt is checked out under AOSP, then create symbolic links instead of downloading sources
cd system/bt mkdir third_party cd third_party ln -s ../../../external/aac aac ln -s ../../../external/libchrome libchrome ln -s ../../../external/libldac libldac ln -s ../../../external/modp_b64 modp_b64 ln -s ../../../external/tinyxml2 tinyxml2 ln -s ../../../external/googletest googletest
cd ~/fluoride/bt gn gen out/Default
cd ~/fluoride/bt ninja -C out/Default all
This will build all targets (the shared library, executables, tests, etc) and put them in out/Default. To build an individual target, replace “all” with the target of your choice, e.g. ninja -C out/Default net_test_osi
.
cd ~/fluoride/bt/out/Default LD_LIBRARY_PATH=./ ./bluetoothtbd -create-ipc-socket=fluoride
Follows the Chromium project Eclipse Setup Instructions until “Optional: Building inside Eclipse” section (don't do that section, we will set it up differently)
Generate Eclipse settings:
cd system/bt gn gen --ide=eclipse out/Default
In Eclipse, do File->Import->C/C++->C/C++ Project Settings, choose the XML location under system/bt/out/Default
Right click on the project. Go to Preferences->C/C++ Build->Builder Settings. Uncheck “Use default build command”, but instead using “ninja -C out/Default”
Goto Behaviour tab, change clean command to “-t clean”