[go: nahoru, domu]
Google Git
Sign in
chromium / chromium / src.git / f4ffe1142763e11f910c2f300e4f8fe9c4c94361
commitf4ffe1142763e11f910c2f300e4f8fe9c4c94361[log] [tgz]
authorAkihiro Ota <akihiroota@chromium.org>Tue Jul 09 20:07:22 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jul 09 20:07:22 2024
treef61dc95b6ad52866a51dfe984c4b9d5f0adb9c20
parent2e3c5120159f669a583d458b392a49eba785112f [diff]
FaceGaze: Move WebCamFaceLandmarker to background

This change implements the move of the WebCamFaceLandmarker from the
camera_stream page (which was a hack added for rapid prototyping) to
the background page (which is where it should live for the MVP). To do
this, a few things needed to happen:

1. We removed the customizable weights from camera_stream.ts, since we
are moving that file into the background context - after some
refactoring, we will add back the logic that allows devs to tune the
FaceLandmarker weights for testing purposes
2. We removed the logic to open the camera_stream page
3. Instead of using the extension messaging system, we now use a
callback to communicate FaceLandmarkerResults to the main FaceGaze
object
4. Since the WebCamFaceLandmarker is now in the background and
automatically initialized, we added logic to avoid initializing it in
tests
5. Some browser tests started flaking from the implementation changes
and needed to be adjusted to account for potential races/timing issues

Bug: b/349149340
Change-Id: Ib10d853b30fe6ea111e62989ec7b96ce3d17faec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5665604
Reviewed-by: Amanda Lin Dietz <aldietz@google.com>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1325077}
9 files changed
tree: f61dc95b6ad52866a51dfe984c4b9d5f0adb9c20
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.