commit | a526d126ca2d9494b24defb0eb2f199e3a5728be | [log] [tgz] |
---|---|---|
author | Ahmed Moussa <ahmedmoussa@google.com> | Wed Feb 14 21:24:33 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 14 21:24:33 2024 |
tree | ddbe96daeda714a8f144f88c1d2446a86836ca15 | |
parent | 4874c89ced0e5b39a062a30e37bcf257d138a6bb [diff] |
[live-preview] Fix GMB issue with Windows When GpuRasterization is not available or if there is no support for D3dSharedImage, rendering GMB frames fails. The video preview is implemented by painting the video frame into a tile via PaintCanvasVideoRenderer in the browser compositor. When the incoming video resource is a GpuMemoryBufferHandle it goes to GpuMemoryBufferHandleHolder which wraps it in a shared image. That should work fine if the tile is GPU rasterized, since the video frame texture to tile texture copy happens on the GPU, but it won't work in case of software raster since rasterization happens in the browser process and GPU texture data is unavailable. This CL provides a fix for that by requesting pre-mapped frames and wraps the SharedMemoryRegion. Bug: b:319273222 Change-Id: I165199ce8f41f1838785c8bd9b132010de106c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5259809 Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> Commit-Queue: Ahmed Moussa <ahmedmoussa@google.com> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/main@{#1260702}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.