| commit | a620cffde420d3343e420f348e870c54fd5379ae | [log] [tgz] |
|---|---|---|
| author | Daniel Libby <dlibby@microsoft.com> | Thu Sep 15 22:46:22 2022 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Sep 15 22:46:22 2022 |
| tree | 242165ede35c67c05f427baf9e9a3a8ab634e3ac | |
| parent | 5fb7f7c213e4fc05d6bfb18570b07b16ec562301 [diff] |
Add kComboBoxSelect internal role Blink exposes two completely things as kPopupButton, and we need to disambiguate. 1. <select size=1> 2. <button aria-haspopup> via AXObject::ButtonRoleType() Currently this disambiguation (in order to expose <select> as combobox and <button> as button role) occurs on the platform side by checking the tag or testing the internal children structure, which is a hack. One negative side-effect of this is that the reverse role mappings in Blink end up reporting buttons with aria-haspopup as 'combobox' in devtools which is very confusing to developers ensuring they have the right roles present in their accessibility trees. This change splits out kPopUpButton, and allows us to more closely match the role mapping through the entire pipeline. There are a handful of places where the new kComboBoxSelect and kPopUpButton are not treated as equivalent in code: - checks for popupbutton then menulistpopup and related children. These were just converted to check for the new kComboBoxSelect role. Generic popup buttons can't ever have this structure anyways. - A couple of locations in Blink that used to check for kPopUpButton then test for HTMLSelect element specifically. - Readonly support for kPopUpButton, since that was the cause of some more special case code. However, in these cases, there should not be any behavioral change. In addition I had to add some output mappings on ChromeVox, since it is directly coupled with the Chromium internal roles. I opted to have these remain the same for now and we can adjust in a follow up CL as appropriate. Bug: 1147422, 1362834 Change-Id: I0f9ca8cb9e7ad2a7aea7ebfeda4931593ca11721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3868204 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1047719}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.