commit | a67ecfcfa6400271dc61467aa6a1139a953aba2f | [log] [tgz] |
---|---|---|
author | Kai Ninomiya <kainino@chromium.org> | Fri Jun 02 23:00:40 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jun 02 23:00:40 2023 |
tree | 7959a83a71c17036ccb26234dd967cdca5019819 | |
parent | 2665c74365ea435ff6a95b1970f1c48c56dbe4cb [diff] |
Revert "[//media] Add RenderableGMBVideoFramePool MultiplanarSI flow on Mac" This reverts commit 60007e376cb8cd470a067102553bcef92445b231. Reason for revert: Gold failures in https://crbug.com/1451025 Original change's description: > [//media] Add RenderableGMBVideoFramePool MultiplanarSI flow on Mac > > This CL adds a flow to RenderableGMBVideoFramePool wherein it creates > Multiplanar SharedImages on Mac. A few notes: > > * I tested the flow with Google Meet visual effects, which I confirmed > (repeatedly :) were broken if the flow wasn't correct > * I enabled the flow only on Mac at this time as I wasn't able to > test on any other platform, and I don't know if further changes might > be required on other platforms > * I added the change to > media/renderers/video_frame_rgba_to_yuva_converter.cc in response to > a gpu-side DCHECK [1] going off in local testing. It seems like it > might need to be generalized in the future. > * The only implementation of the new Context::CreateSI() method that > is invoked in this flow is WebGraphicsContext3DVideoFramePool, but I > filled in the others for completeness > > This patch is based on a prototype by hitawala@. > > [1] https://source.chromium.org/chromium/chromium/src/+/main:gpu/command_buffer/service/copy_shared_image_helper.cc;l=642-644?q=copy_shared_image&ss=chromium > > Change-Id: I57d1ea8a0b2b5c35ddee7468f48a199b06f46f5d > Bug: 1429004 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4488909 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Colin Blundell <blundell@chromium.org> > Reviewed-by: Saifuddin Hitawala <hitawala@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1152495} Bug: 1451025 Bug: 1429004 Change-Id: Ie61c35797a5102c315d9992fba98c2a932e5e1d0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584419 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Owners-Override: Kai Ninomiya <kainino@google.com> Cr-Commit-Position: refs/heads/main@{#1152827}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.