commit | a1c5064c948ec2a53bb3cce7210ebfda6a212dd1 | [log] [tgz] |
---|---|---|
author | Peter Marshall <petermarshall@chromium.org> | Wed Apr 26 07:39:54 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 26 07:39:54 2023 |
tree | b3056015741624d1c595352bcfc27105bcf2fabd | |
parent | 79801c5d74d3ec7598b57aeee76d91d7f70056a5 [diff] |
Reland "[Office upload] Use BrowserListObserver to wait for created Files app" This is a reland of commit 9089c92681121f77bda5c622d902dd94cc0aa80d This is a clean reland. The failure was caused by a flaky test, fixed in crrev.com/c/4463978, crrev.com/c/4478591 Original change's description: > [Office upload] Use BrowserListObserver to wait for created Files app > > When we didn't have a Files app window to use as a modal parent for > our dialog, we created a new Files app window and used it as the > parent. But this didn't work because the callback we provide to > ShowItemInFolder gets called early in the launch process, before > the actual Files app is launched. > > Instead use BrowserListObserver to catch when a new Browser is > added, check that it's the Files app window we were expecting, > and launch our dialog with this window as the modal parent. > > Several tests didn't use "real" files, they just created > FileSystemURLs to plausible locations. This meant that > ShowItemInFolder() failed to launch Files app in tests, which > now causes CloudOpenTask to never make progress. Use the default > browser() in several tests to avoid this problem. > > Update NewModalParentCreatedWithExisting to more directly > capture and check the Browser that was created by CloudOpenTask. > > Bug: b:275950760 > Change-Id: I4f3b9f1891e0b32a2c426333eebcd5c742359833 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4431739 > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Cassy Chun-Crogan <cassycc@google.com> > Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1133586} Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b:275950760 Change-Id: I00ad795ce62ad7e21b37507600ea42ae7b98ae61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4464338 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Cassy Chun-Crogan <cassycc@google.com> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1135772}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.