Pass skia gold args to blink_platform_unittests
The target will run skia gold based pixel tests.
Bug: 1523036
Change-Id: I2d72372672afb2668618d01269b406264ed34dc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5269268
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: John Stiles <johnstiles@google.com>
Cr-Commit-Position: refs/heads/main@{#1256375}
diff --git a/infra/config/generated/testing/test_suites.pyl b/infra/config/generated/testing/test_suites.pyl
index 9f9d564..54f508e8 100644
--- a/infra/config/generated/testing/test_suites.pyl
+++ b/infra/config/generated/testing/test_suites.pyl
@@ -108,7 +108,11 @@
'android_pie_rel_reduced_capacity_gtests': {
'android_browsertests': {},
- 'blink_platform_unittests': {},
+ 'blink_platform_unittests': {
+ 'mixins': [
+ 'skia_gold_test',
+ ],
+ },
'cc_unittests': {},
'content_browsertests': {
'swarming': {
@@ -835,7 +839,11 @@
'base_unittests': {},
'blink_common_unittests': {},
'blink_heap_unittests': {},
- 'blink_platform_unittests': {},
+ 'blink_platform_unittests': {
+ 'mixins': [
+ 'skia_gold_test',
+ ],
+ },
'boringssl_crypto_tests': {},
'boringssl_ssl_tests': {},
'capture_unittests': {
@@ -2185,7 +2193,11 @@
'blink_common_unittests': {},
'blink_fuzzer_unittests': {},
'blink_heap_unittests': {},
- 'blink_platform_unittests': {},
+ 'blink_platform_unittests': {
+ 'mixins': [
+ 'skia_gold_test',
+ ],
+ },
'blink_unittests': {},
'blink_unittests_v2': {},
'boringssl_crypto_tests': {},
@@ -4029,6 +4041,9 @@
'blink_fuzzer_unittests': {},
'blink_heap_unittests': {},
'blink_platform_unittests': {
+ 'mixins': [
+ 'skia_gold_test',
+ ],
'args': [
'--test-launcher-bot-mode',
'--test-launcher-filter-file=testing/buildbot/filters/ios.blink_platform_unittests.filter',
@@ -4537,7 +4552,11 @@
'app_shell_unittests': {},
'base_unittests': {},
'blink_heap_unittests': {},
- 'blink_platform_unittests': {},
+ 'blink_platform_unittests': {
+ 'mixins': [
+ 'skia_gold_test',
+ ],
+ },
'blink_unittests': {},
'blink_unittests_v2': {},
'cc_unittests': {},
diff --git a/infra/config/targets/tests.star b/infra/config/targets/tests.star
index 9c25049..d944ec0 100644
--- a/infra/config/targets/tests.star
+++ b/infra/config/targets/tests.star
@@ -197,6 +197,9 @@
targets.tests.gtest_test(
name = "blink_platform_unittests",
+ mixins = [
+ "skia_gold_test",
+ ],
)
targets.tests.isolated_script_test(
diff --git a/testing/buildbot/chrome.json b/testing/buildbot/chrome.json
index 294d3cf..553b00c1 100644
--- a/testing/buildbot/chrome.json
+++ b/testing/buildbot/chrome.json
@@ -2805,10 +2805,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04",
diff --git a/testing/buildbot/chromium.android.fyi.json b/testing/buildbot/chromium.android.fyi.json
index c134c84c..73d31cf 100644
--- a/testing/buildbot/chromium.android.fyi.json
+++ b/testing/buildbot/chromium.android.fyi.json
@@ -551,7 +551,8 @@
"args": [
"--gs-results-bucket=chromium-result-details",
"--recover-devices",
- "--avd-config=../../tools/android/avd/proto/android_31_google_atd_x64.textpb"
+ "--avd-config=../../tools/android/avd/proto/android_31_google_atd_x64.textpb",
+ "--git-revision=${got_revision}"
],
"merge": {
"args": [
@@ -563,6 +564,11 @@
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
@@ -4621,7 +4627,8 @@
"args": [
"--gs-results-bucket=chromium-result-details",
"--recover-devices",
- "--avd-config=../../tools/android/avd/proto/android_32_google_atd_x64_foldable.textpb"
+ "--avd-config=../../tools/android/avd/proto/android_32_google_atd_x64_foldable.textpb",
+ "--git-revision=${got_revision}"
],
"merge": {
"args": [
@@ -4633,6 +4640,11 @@
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
@@ -8334,7 +8346,8 @@
"args": [
"--gs-results-bucket=chromium-result-details",
"--recover-devices",
- "--avd-config=../../tools/android/avd/proto/android_33_google_atd_x64.textpb"
+ "--avd-config=../../tools/android/avd/proto/android_33_google_atd_x64.textpb",
+ "--git-revision=${got_revision}"
],
"merge": {
"args": [
@@ -8346,6 +8359,11 @@
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
diff --git a/testing/buildbot/chromium.android.json b/testing/buildbot/chromium.android.json
index ac08ae3..987b5d8 100644
--- a/testing/buildbot/chromium.android.json
+++ b/testing/buildbot/chromium.android.json
@@ -2213,7 +2213,8 @@
"args": [
"--gs-results-bucket=chromium-result-details",
"--recover-devices",
- "--avd-config=../../tools/android/avd/proto/android_30_google_apis_x86.textpb"
+ "--avd-config=../../tools/android/avd/proto/android_30_google_apis_x86.textpb",
+ "--git-revision=${got_revision}"
],
"merge": {
"args": [
@@ -2225,6 +2226,11 @@
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
@@ -6044,7 +6050,8 @@
"--use-persistent-shell",
"--gs-results-bucket=chromium-result-details",
"--recover-devices",
- "--avd-config=../../tools/android/avd/proto/android_31_google_apis_x64.textpb"
+ "--avd-config=../../tools/android/avd/proto/android_31_google_apis_x64.textpb",
+ "--git-revision=${got_revision}"
],
"description": "Run with android_31_google_apis_x64",
"isolate_profile_data": true,
@@ -6058,6 +6065,11 @@
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
@@ -10371,7 +10383,8 @@
"args": [
"--gs-results-bucket=chromium-result-details",
"--recover-devices",
- "--avd-config=../../tools/android/avd/proto/android_32_google_apis_x64_foldable.textpb"
+ "--avd-config=../../tools/android/avd/proto/android_32_google_apis_x64_foldable.textpb",
+ "--git-revision=${got_revision}"
],
"merge": {
"args": [
@@ -10383,6 +10396,11 @@
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
@@ -14035,7 +14053,8 @@
"args": [
"--gs-results-bucket=chromium-result-details",
"--recover-devices",
- "--avd-config=../../tools/android/avd/proto/android_33_google_apis_x64.textpb"
+ "--avd-config=../../tools/android/avd/proto/android_33_google_apis_x64.textpb",
+ "--git-revision=${got_revision}"
],
"description": "Run with android_33_google_apis_x64",
"merge": {
@@ -14048,6 +14067,11 @@
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
@@ -18011,7 +18035,8 @@
"args": [
"--gs-results-bucket=chromium-result-details",
"--recover-devices",
- "--avd-config=../../tools/android/avd/proto/android_34_google_apis_x64.textpb"
+ "--avd-config=../../tools/android/avd/proto/android_34_google_apis_x64.textpb",
+ "--git-revision=${got_revision}"
],
"description": "Run with android_34_google_apis_x64",
"merge": {
@@ -18024,6 +18049,11 @@
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
@@ -21868,7 +21898,8 @@
{
"args": [
"--gs-results-bucket=chromium-result-details",
- "--recover-devices"
+ "--recover-devices",
+ "--git-revision=${got_revision}"
],
"merge": {
"args": [
@@ -21880,6 +21911,11 @@
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
@@ -30761,7 +30797,8 @@
"--use-persistent-shell",
"--gs-results-bucket=chromium-result-details",
"--recover-devices",
- "--avd-config=../../tools/android/avd/proto/generic_android26.textpb"
+ "--avd-config=../../tools/android/avd/proto/generic_android26.textpb",
+ "--git-revision=${got_revision}"
],
"isolate_profile_data": true,
"merge": {
@@ -30774,6 +30811,11 @@
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
@@ -35502,7 +35544,8 @@
"args": [
"--use-persistent-shell",
"--gs-results-bucket=chromium-result-details",
- "--recover-devices"
+ "--recover-devices",
+ "--git-revision=${got_revision}"
],
"isolate_profile_data": true,
"merge": {
@@ -35515,6 +35558,11 @@
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
@@ -36547,7 +36595,8 @@
"args": [
"--gs-results-bucket=chromium-result-details",
"--recover-devices",
- "--avd-config=../../tools/android/avd/proto/android_28_google_apis_x86.textpb"
+ "--avd-config=../../tools/android/avd/proto/android_28_google_apis_x86.textpb",
+ "--git-revision=${got_revision}"
],
"merge": {
"args": [
@@ -36559,6 +36608,11 @@
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
diff --git a/testing/buildbot/chromium.cft.json b/testing/buildbot/chromium.cft.json
index 43f85c3..f1e4959 100644
--- a/testing/buildbot/chromium.cft.json
+++ b/testing/buildbot/chromium.cft.json
@@ -152,11 +152,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "arm64",
@@ -2113,11 +2121,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
@@ -3953,11 +3969,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -5581,11 +5605,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
diff --git a/testing/buildbot/chromium.chromiumos.json b/testing/buildbot/chromium.chromiumos.json
index 2e4ab57..8a81b8a 100644
--- a/testing/buildbot/chromium.chromiumos.json
+++ b/testing/buildbot/chromium.chromiumos.json
@@ -1651,10 +1651,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -3159,11 +3167,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -4724,11 +4740,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
diff --git a/testing/buildbot/chromium.coverage.json b/testing/buildbot/chromium.coverage.json
index 66c1bf7d..df8d767 100644
--- a/testing/buildbot/chromium.coverage.json
+++ b/testing/buildbot/chromium.coverage.json
@@ -1253,7 +1253,8 @@
{
"args": [
"--gs-results-bucket=chromium-result-details",
- "--recover-devices"
+ "--recover-devices",
+ "--git-revision=${got_revision}"
],
"isolate_profile_data": true,
"merge": {
@@ -1266,6 +1267,11 @@
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
@@ -3958,7 +3964,8 @@
"--use-persistent-shell",
"--gs-results-bucket=chromium-result-details",
"--recover-devices",
- "--avd-config=../../tools/android/avd/proto/generic_android26.textpb"
+ "--avd-config=../../tools/android/avd/proto/generic_android26.textpb",
+ "--git-revision=${got_revision}"
],
"isolate_profile_data": true,
"merge": {
@@ -3971,6 +3978,11 @@
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
@@ -8565,13 +8577,19 @@
{
"args": [
"--code-coverage-dir=${ISOLATED_OUTDIR}",
- "--device-spec=virtual_device_large"
+ "--device-spec=virtual_device_large",
+ "--git-revision=${got_revision}"
],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
@@ -16620,11 +16638,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
@@ -18004,11 +18030,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
@@ -19898,11 +19932,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
@@ -21381,11 +21423,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -22659,11 +22709,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Windows-10-19045"
diff --git a/testing/buildbot/chromium.fuchsia.fyi.json b/testing/buildbot/chromium.fuchsia.fyi.json
index 9cd9aab..dd2bb14 100644
--- a/testing/buildbot/chromium.fuchsia.fyi.json
+++ b/testing/buildbot/chromium.fuchsia.fyi.json
@@ -119,10 +119,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "arm64",
@@ -1049,10 +1057,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"kvm": "1",
@@ -2076,10 +2092,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"kvm": "1",
diff --git a/testing/buildbot/chromium.fuchsia.json b/testing/buildbot/chromium.fuchsia.json
index 815629c..b2f21b1 100644
--- a/testing/buildbot/chromium.fuchsia.json
+++ b/testing/buildbot/chromium.fuchsia.json
@@ -120,10 +120,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "arm64",
@@ -1093,11 +1101,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"kvm": "1",
diff --git a/testing/buildbot/chromium.fyi.json b/testing/buildbot/chromium.fyi.json
index a99b78d..fba3518a 100644
--- a/testing/buildbot/chromium.fyi.json
+++ b/testing/buildbot/chromium.fyi.json
@@ -250,10 +250,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "arm64",
@@ -1947,7 +1955,15 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"test": "blink_platform_unittests",
"test_id_prefix": "ninja://third_party/blink/renderer/platform:blink_platform_unittests/"
},
@@ -5015,12 +5031,18 @@
"${ISOLATED_OUTDIR}",
"--xcode-build-version",
"15e5178i",
- "--xctest"
+ "--xctest",
+ "--git-revision=${got_revision}"
],
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "blink_platform_unittests iPhone 14 17.2",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
@@ -40280,10 +40302,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
@@ -40979,10 +41009,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
@@ -41908,10 +41946,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04",
@@ -43387,10 +43433,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04",
@@ -45077,11 +45131,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04",
@@ -47405,10 +47467,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -49694,11 +49764,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
diff --git a/testing/buildbot/chromium.linux.json b/testing/buildbot/chromium.linux.json
index b9bc1df..5676917 100644
--- a/testing/buildbot/chromium.linux.json
+++ b/testing/buildbot/chromium.linux.json
@@ -80,10 +80,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
@@ -1042,11 +1050,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
@@ -3083,13 +3099,19 @@
"args": [
"--no-xvfb",
"--use-weston",
- "--ozone-platform=wayland"
+ "--ozone-platform=wayland",
+ "--git-revision=${got_revision}"
],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
@@ -4706,10 +4728,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
diff --git a/testing/buildbot/chromium.mac.json b/testing/buildbot/chromium.mac.json
index 6960fea..714afd4 100644
--- a/testing/buildbot/chromium.mac.json
+++ b/testing/buildbot/chromium.mac.json
@@ -152,10 +152,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -1665,11 +1673,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -3291,11 +3307,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -4920,11 +4944,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -6627,10 +6659,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -23024,10 +23064,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "arm64",
@@ -24503,11 +24551,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"ci_only": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "arm64",
@@ -26066,11 +26122,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"ci_only": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "arm64",
diff --git a/testing/buildbot/chromium.memory.fyi.json b/testing/buildbot/chromium.memory.fyi.json
index 70db4c3..22af5a1 100644
--- a/testing/buildbot/chromium.memory.fyi.json
+++ b/testing/buildbot/chromium.memory.fyi.json
@@ -168,12 +168,18 @@
},
{
"args": [
- "--test-launcher-print-test-stdio=always"
+ "--test-launcher-print-test-stdio=always",
+ "--git-revision=${got_revision}"
],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -1684,12 +1690,18 @@
},
{
"args": [
- "--test-launcher-print-test-stdio=always"
+ "--test-launcher-print-test-stdio=always",
+ "--git-revision=${got_revision}"
],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
@@ -3161,11 +3173,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
@@ -4408,12 +4428,18 @@
},
{
"args": [
- "--test-launcher-print-test-stdio=always"
+ "--test-launcher-print-test-stdio=always",
+ "--git-revision=${got_revision}"
],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -4737,12 +4763,18 @@
},
{
"args": [
- "--test-launcher-print-test-stdio=always"
+ "--test-launcher-print-test-stdio=always",
+ "--git-revision=${got_revision}"
],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
diff --git a/testing/buildbot/chromium.memory.json b/testing/buildbot/chromium.memory.json
index fa074031..0b0e409e 100644
--- a/testing/buildbot/chromium.memory.json
+++ b/testing/buildbot/chromium.memory.json
@@ -160,12 +160,18 @@
},
{
"args": [
- "--test-launcher-print-test-stdio=always"
+ "--test-launcher-print-test-stdio=always",
+ "--git-revision=${got_revision}"
],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
@@ -1622,10 +1628,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
@@ -2960,12 +2974,18 @@
},
{
"args": [
- "--test-launcher-print-test-stdio=always"
+ "--test-launcher-print-test-stdio=always",
+ "--git-revision=${got_revision}"
],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -4654,12 +4674,18 @@
},
{
"args": [
- "--test-launcher-print-test-stdio=always"
+ "--test-launcher-print-test-stdio=always",
+ "--git-revision=${got_revision}"
],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -6296,12 +6322,18 @@
},
{
"args": [
- "--test-launcher-print-test-stdio=always"
+ "--test-launcher-print-test-stdio=always",
+ "--git-revision=${got_revision}"
],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -7812,12 +7844,18 @@
},
{
"args": [
- "--test-launcher-print-test-stdio=always"
+ "--test-launcher-print-test-stdio=always",
+ "--git-revision=${got_revision}"
],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
@@ -9304,12 +9342,18 @@
},
{
"args": [
- "--test-launcher-print-test-stdio=always"
+ "--test-launcher-print-test-stdio=always",
+ "--git-revision=${got_revision}"
],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -11101,7 +11145,8 @@
{
"args": [
"--gs-results-bucket=chromium-result-details",
- "--recover-devices"
+ "--recover-devices",
+ "--git-revision=${got_revision}"
],
"merge": {
"args": [
@@ -11113,6 +11158,11 @@
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
@@ -15739,13 +15789,19 @@
"args": [
"--test-launcher-print-test-stdio=always",
"--combine-ash-logs-on-bots",
- "--asan-symbolize-output"
+ "--asan-symbolize-output",
+ "--git-revision=${got_revision}"
],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -17678,10 +17734,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
@@ -18886,10 +18950,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"os": "Windows-10-19045"
diff --git a/testing/buildbot/chromium.win.json b/testing/buildbot/chromium.win.json
index d9e855b..2534dd4 100644
--- a/testing/buildbot/chromium.win.json
+++ b/testing/buildbot/chromium.win.json
@@ -259,11 +259,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -2447,10 +2455,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -4104,11 +4120,19 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "x86-64",
@@ -6057,10 +6081,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "arm64",
@@ -7690,10 +7722,18 @@
"test_id_prefix": "ninja://third_party/blink/renderer/platform/heap:blink_heap_unittests/"
},
{
+ "args": [
+ "--git-revision=${got_revision}"
+ ],
"merge": {
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"name": "blink_platform_unittests",
+ "precommit_args": [
+ "--gerrit-issue=${patch_issue}",
+ "--gerrit-patchset=${patch_set}",
+ "--buildbucket-id=${buildbucket_build_id}"
+ ],
"swarming": {
"dimensions": {
"cpu": "arm64",
diff --git a/testing/buildbot/test_suites.pyl b/testing/buildbot/test_suites.pyl
index 9f9d564..54f508e8 100644
--- a/testing/buildbot/test_suites.pyl
+++ b/testing/buildbot/test_suites.pyl
@@ -108,7 +108,11 @@
'android_pie_rel_reduced_capacity_gtests': {
'android_browsertests': {},
- 'blink_platform_unittests': {},
+ 'blink_platform_unittests': {
+ 'mixins': [
+ 'skia_gold_test',
+ ],
+ },
'cc_unittests': {},
'content_browsertests': {
'swarming': {
@@ -835,7 +839,11 @@
'base_unittests': {},
'blink_common_unittests': {},
'blink_heap_unittests': {},
- 'blink_platform_unittests': {},
+ 'blink_platform_unittests': {
+ 'mixins': [
+ 'skia_gold_test',
+ ],
+ },
'boringssl_crypto_tests': {},
'boringssl_ssl_tests': {},
'capture_unittests': {
@@ -2185,7 +2193,11 @@
'blink_common_unittests': {},
'blink_fuzzer_unittests': {},
'blink_heap_unittests': {},
- 'blink_platform_unittests': {},
+ 'blink_platform_unittests': {
+ 'mixins': [
+ 'skia_gold_test',
+ ],
+ },
'blink_unittests': {},
'blink_unittests_v2': {},
'boringssl_crypto_tests': {},
@@ -4029,6 +4041,9 @@
'blink_fuzzer_unittests': {},
'blink_heap_unittests': {},
'blink_platform_unittests': {
+ 'mixins': [
+ 'skia_gold_test',
+ ],
'args': [
'--test-launcher-bot-mode',
'--test-launcher-filter-file=testing/buildbot/filters/ios.blink_platform_unittests.filter',
@@ -4537,7 +4552,11 @@
'app_shell_unittests': {},
'base_unittests': {},
'blink_heap_unittests': {},
- 'blink_platform_unittests': {},
+ 'blink_platform_unittests': {
+ 'mixins': [
+ 'skia_gold_test',
+ ],
+ },
'blink_unittests': {},
'blink_unittests_v2': {},
'cc_unittests': {},