[go: nahoru, domu]

slim: Implement rounded corner

The implementation is not entirely based on cc as cc's implementation
has bugs.

The RRectF (in MaskFilterInfo) is on the SharedQuadState is in target
space. Setting a non-empty rounded corner also clips the subtree to the
layer; this is implemented exactly as if MaskToBounds is set.

There are 2 cases where a new render pass is needed:
* The layer is not axis aligned. For similar reason as clip, RRectF
  stores an axis aligned rect. There is no special handling added since
  MaskToBounds implementation already creates new pass for this case.
* Parent layer already has a rounded corner. In this case, the child
  layer is draw to the new pass with its rounded corner, and the
  RenderPassDrawQuad draws with the parent rounded corner.

Observed difference from cc:
* Slim always sets fast rounded corner.
* Slim supports rotating rounded corner. cc appears to just break
  rounded corner with rotation.
* No need to create new pass if there is only one (axis-aligned)
  rounded corner layer on the path to root. Any number of children of
  the that layer can use the same RRectF (in MaskFilterInfo), since it
  is target space. There is no need for additional render pass.

Bug: 1399283
Change-Id: I24a31c6424c1108b7da92edf2ec26a8f72d2315b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4457397
Commit-Queue: Bo Liu <boliu@chromium.org>
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1135574}
10 files changed
tree: 781e35805c1c0125f10354af2060128b8a6314c9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.