commit | abe9fc63d510dd80d342d72f0bd44fcc276a3fbb | [log] [tgz] |
---|---|---|
author | Scott Sheehan <ssheehan@microsoft.com> | Mon Feb 19 08:42:25 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Feb 19 08:42:25 2024 |
tree | ad2e4280ff2690b207e4eaa24029163db309e8b9 | |
parent | 9a3484c163cccff84ac3c936018815a586b80bfa [diff] |
Fix dangling pointer issues in system_signals_service unittests. The constructors for these unittests create a MockFileSystemService sub-object owned by a unique_ptr and moves them to `${platform_}system_signals_service_`. The test holds on to the sub-objects via raw_ptr. This causes dangling pointer detection to fire during test destruction as the ordering of the member variable (in the unittest) causes the owning object to be destroyed first (thus making the sub-object dangling -- for an instant). Re-ordering the raw_ptr sub-object such that it is destroyed first avoids this problem. the Windows version though). Disclaimer: I didn't verify the Linux & Mac fixes (I did confirm Change-Id: Ibcdd5a54b2db8d2a96e8a6b8392c90449c30399e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5303581 Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Sébastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262274}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.