commit | ae3db364adf5b7489fb167971eb6a07a7c56aeb9 | [log] [tgz] |
---|---|---|
author | Dale Curtis <dalecurtis@chromium.org> | Mon Mar 11 18:58:08 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 11 18:58:08 2024 |
tree | 27638ab3a44ed9d20d254ae2fcaa014a76442135 | |
parent | e1732d71e011dbf53c22cebfacf1d54445553ba6 [diff] |
Revert "[M123] [Audio] Propagate socket errors to sinks and sources. Prevent reuse." This reverts commit 0105c8e541581f18d0a7f6e3a8d629f917385550. Reason for revert: Exposing latent threading issues in audio input device users and not need in 123 since https://chromium-review.googlesource.com/c/chromium/src/+/5354149 was reverted. Original change's description: > [M123] [Audio] Propagate socket errors to sinks and sources. Prevent reuse. > > M123: This drops AudioInputDevice and AudioOutputDevice tests which had > merge conflicts. > > If the browser side closes the socket the renderer is only notified > through a failure to read from the socket. This error was being dropped > instead of propagated to the RenderCallback and CaptureCallback. > > This error signal is then used to prevent reuse of AudioRendererMixer > instances. This fixes the linked issue (same-origin navigations where > the mixer is reused between navigations). > > There may still be constructions where a RenderFrame which creates a > shared sink is closed while the sink is being used. I haven't yet been > able to construct such a scenario though. > > Bug: 326903566 > > (cherry picked from commit 7c882251cf9d4f6fe2b212084674f1ab62897fea) > > Change-Id: I45c6ce12327315540590dab9ae545fa7327a9d83 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5331283 > Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Original-Commit-Position: refs/heads/main@{#1266838} > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5336610 > Auto-Submit: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> > Cr-Commit-Position: refs/branch-heads/6312@{#372} > Cr-Branched-From: 6711dcdae48edaf98cbc6964f90fac85b7d9986e-refs/heads/main@{#1262506} Bug: 326903566, 328908259 Change-Id: I259bcc5f907783a16b719cc667a7b16ca71053ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5360711 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/branch-heads/6312@{#515} Cr-Branched-From: 6711dcdae48edaf98cbc6964f90fac85b7d9986e-refs/heads/main@{#1262506}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.