commit | b402dc70dabe723782f11de26d268dfa7fe316f3 | [log] [tgz] |
---|---|---|
author | Pavol Marko <pmarko@chromium.org> | Tue Dec 05 11:47:26 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Dec 05 11:47:26 2023 |
tree | 79561d5b2172b5683db8eeaddd5c7ce43d61dcc6 | |
parent | 91c4570ac3b7f3ee41dd23eec601dfe349426cfb [diff] |
[gardener] Revert "Cleanup network::mojom::URLResponseHead" This reverts commit 9c9653781023db9bbd86c2e873bffdcbaae25e28. Reason for revert: I think this is causing MSan failures, e.g. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/39949 -> #0 0x55d134f77a97 in blink::ResourceFetcher::HandleLoaderFinish(blink::Resource*, base::TimeTicks, blink::ResourceFetcher::LoaderFinishType, unsigned int) ./../../third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc:2105:9 is accessing if (resource->GetResponse().ShouldPopulateResourceTiming()) which seems uninitialized since this CL. Original change's description: > Cleanup network::mojom::URLResponseHead > > While investigating https://crbug.com/1507770 I noticed two things: > 1. ct_policy_compliance is not used any more. > - ct_policy_compliance was introduced by https://crrev.com/534288. > - It is not used after https://crrev.com/957351. > 2. web_bundle_url is used only checking if the response is an inner > response of a WebBundle. > > So we can remove ct_policy_compliance param, and replace web_bundle_url > param with a new bool param. > > The size of network::mojom::URLResponseHead decreases from 1072 bytes to > 944 bytes. > > Bug: 1507770 > Change-Id: Iadf6ec88b04103141cb7f0c534af9b4ca6b2237c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5082541 > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1233197} Bug: 1507770 Change-Id: I0f0e9d7cc049ed2ebfca1278ae0d4ebfa9b95848 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5087933 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Pavol Marko <pmarko@chromium.org> Auto-Submit: Pavol Marko <pmarko@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1233264}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.