commit | b4d21ecc7bee46a98b89be86d158961b05652448 | [log] [tgz] |
---|---|---|
author | Wenyu Fu <wenyufu@google.com> | Tue Aug 15 03:38:49 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Aug 15 03:38:49 2023 |
tree | 28183651c622feea5c621cfff6103f973e3366bc | |
parent | 2af1c13a602ae8d558bcdbe2926322253827ab80 [diff] |
[Share] Use cleaner intent to remove top ChooserActivity The original CL cause a regression for CCT, as sending intent to itself creates a new CCT session. Based on the original CL, adding an intent extra so when activities receive the new intent, it'll be dropped properly. Recording: https://drive.google.com/file/d/1AZMhz-QWxQLuSZr8Tk-mFtGYK59aUzSL/view?usp=drive_link&resourcekey=0-ZffGjQClTpHLwlyLcp7mgw (Description from original CL: crrev.com/c/4750566) [Share] Remove TargetChosenReceiver when WindowAndroid destroyed Android share sheet is showing with as ChooserActivity on top of Chrome. When theme switches, Chrome activity is recreated, so the previous stored custom actions should go away since they are referencing the old activity. As a result, the custom actions on the share sheet becomes no-op once selected. This CL include the fix that: * Remove the weak reference to Activity and WindowAndroid once it is removed from the UserDataHost (in WindowAndroid) * Close the share sheet. This is done by sending an intent with Intent.FLAG_ACTIVITY_CLEAR_TOP targeting to the dispatching activity. Bug: 1470978, 1470036 Change-Id: I6c9efb35f1e77c92e78bfbe6a3d8220419319e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4763472 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/main@{#1183495}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.