commit | b68eb0ac04ec2d96531b07e53e075c6e34cd8d07 | [log] [tgz] |
---|---|---|
author | Ted Choc <tedchoc@chromium.org> | Tue Jul 20 20:56:08 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jul 20 20:56:08 2021 |
tree | d6e3741c3d711137696e3af5290cd9480ff0a642 | |
parent | 9b79b2447671f52e2e64785f03f0f3989621cb15 [diff] |
Fix MinidumpUploadServiceImpl to add application listener on UiThread. ApplicationListener internally uses ObserverList to track observers, and while ObserverList says it should only be used on a single thread, we violate that condition a lot (especially in tests). Initially, the CL was added a ThreadChecker to ObserverList that was default enabled, but this broke THE WORLD. So, this instead adds one that is disabled by default using a static boolean, which allows slowly addressing the tests. In the meantime, this CL attempts to solve some of the easier test issues and low hanging fruit. BUG=1225878 Change-Id: I745d4c8d382d5af4bde4c8450abdb9bae0c33596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3031817 Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: ssid <ssid@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#903642}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.