commit | b6a52a14ba664b3a462c93f7ae5dba862981b837 | [log] [tgz] |
---|---|---|
author | Andrew Xu <andrewxu@chromium.org> | Tue Jul 12 21:02:18 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jul 12 21:02:18 2022 |
tree | d3ca16bc2ed26ef052cc6f2c4b00af293a61cb1a | |
parent | 579c32004e630bcd8a6e07a0ef64f4be92eb0caa [diff] |
[Shelf] Refactor: use a non-inline method to access LoginShelfView With this CL, the LoginShelfView instance that resides in ShelfWidget is accessed through `ShelfWidget::GetLoginShelfView()` rather than `ShelfWidget::login_shelf_view()` or the pointer to the instance. It helps the subsequent CLs to move LoginShelfView to its own widget. This CL should not bring any noticeable changes. Bug: 1197052 Change-Id: I405693f6c37defa99c70134d11d96e33f230546f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3752057 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1023407}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.