[go: nahoru, domu]

[M123] Revert "Improve AudioRendererMixer sharing across RenderFrames."

This reverts commit a6068ebab3469d9d7793381987b1168434afaabe.

Reason for revert: Causing too many unforeseen consequences, see
327884890, 327489297

Original change's description:
> Improve AudioRendererMixer sharing across RenderFrames.
>
> It's common for a page to have a lot of YouTube embeds. With the
> current code, none of those embeds share a mixer and thus can
> trigger the 50 physical stream limit quickly.
>
> AFAICT, there's no good reason to prevent sharing of these streams
> across render frames when the default device is used. They are
> output only and an uncompromised renderer can't directly observe
> any effects (readback for WebAudio and MediaStreams happens
> asynchronously below the shared output).
>
> Often the default device is already being shared at the OS level,
> so any demultiplexing we do in the renderer seems pointless.
>
> Looking through the history we've always limited the sharing to
> per RenderFrameID, but it was only out of an abundance of caution
> rather than a particular concern.
>
> For non-default devices there's good reasons we shouldn't share:
> permissions are required per-origin to access the non-default
> device.
>
> R=olka, tguilbert
>
> Bug: b/314766691
> Change-Id: I7ee6865eb675962aff2aeedcd7290666b38c91e5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5185891
> Commit-Queue: Olga Sharonova <olka@chromium.org>
> Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Olga Sharonova <olka@chromium.org>
> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1245750}

(cherry picked from commit 5f20e0e777c3820b92b85fa941a888fe0a50750d)

Bug: b/314766691, b/327489297, b/327884890
Change-Id: Idb20538593c6303900ebc6062501b424974cbb55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5354149
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1269893}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5356349
Cr-Commit-Position: refs/branch-heads/6312@{#526}
Cr-Branched-From: 6711dcdae48edaf98cbc6964f90fac85b7d9986e-refs/heads/main@{#1262506}
2 files changed
tree: 68a239770550c76561cfc0c42455081e6adc8c06
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.