commit | b8ca5f53e6a7aa6c8bd21062d1f2d38c0731f16f | [log] [tgz] |
---|---|---|
author | Omer Katz <omerkatz@chromium.org> | Fri Feb 02 07:59:00 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Feb 02 07:59:00 2024 |
tree | 62c6af0bcf1275aed876c1331597f64c5b3d7e60 | |
parent | a565c32851c40fe70dd41d0e8ff04ef76b972e27 [diff] |
Adjust CSSSelectorList tracing We're improving the clang plugin for blink gc so that it alerts on untraced array of traceable objects. Due to other technical limitations of the plugin, it is not able to deduce that first_selector_ is traced from the current implementation of the Trace method. Specifically, it needs to see that the field is accessed (the check can't peer into the First() getter method). This CL adjusts the Trace method so that the plugin can correctly "understand" it. Bug: chromium:1480476 Change-Id: I2c035003483c6c4ffff22040498518fab7476d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5253450 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255465}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.