commit | b2eb83c061211b45d060c848ddd3ff3ba450596b | [log] [tgz] |
---|---|---|
author | Bruce Dawson <brucedawson@chromium.org> | Thu Jun 23 19:20:27 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jun 23 19:20:27 2022 |
tree | f8337f68a683d126946328edebe943ff2e719280 | |
parent | 0325ca93fd2c479b095cf2db4383609df30aba03 [diff] |
Switch tools\checkperms to Pylint 2.7 Switching tools\checkperms to Pylint 2.7 triggers this warnings, all easily resolved: checkperms.py:195:9: R1729: Use a generator instead 'all(set(path).issubset(VALID_CHARS) for path in paths)' (use-a-generator) checkperms.py:213:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) checkperms.py:284:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) checkperms.py:343:0: R0205: Class 'ApiBase' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) Bug: 1333587 Change-Id: I3fd5ae2a0d60d12691716f93843bff634f12ecbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3721590 Reviewed-by: Jesse McKenna <jessemckenna@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/main@{#1017292}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.