| commit | bc5cd82eff89c73415aaf537ecbb2f809d9ee2ed | [log] [tgz] |
|---|---|---|
| author | Adrienne Walker <enne@chromium.org> | Tue Oct 31 21:58:15 2017 |
| committer | Commit Bot <commit-bot@chromium.org> | Tue Oct 31 21:58:15 2017 |
| tree | 1025ebd161e81e2bea4fdc95453a0ea361c1da25 | |
| parent | a9ff9281d5c4ead62b89427baa7bf3e011b33dce [diff] |
oop: Fix flashing by moving preamble to gles2_implemntation The https://chromium-review.googlesource.com/726979 patch caused some bugs with --enable-oop-rasterization was on. In particular, by adding saves and restores, it wrapped all the "preamble" logic for the first RasterCHROMIUM with the setup logic in a save/restore. This caused any partial raster tile to be incorrect and caused flashing. This patch moves the preamble logic into the RasterCHROMIUM call itself, addressing a TODO in SerializeHelper. This is needed for the future anyway so that the underlying tracking SkCanvas can have the correct state for image decode querying. By moving the preamble logic, saves/restores can be added to real DrawRecords and not the fake preamble DrawRecord and the flashing bug is also fixed. Bug: 758350 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I64b3ee698e7712e55ed0170d1d77b62d8a87b72a Reviewed-on: https://chromium-review.googlesource.com/745523 Commit-Queue: enne <enne@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#512969}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .