[go: nahoru, domu]

Limit the number of `PermissionObserver` handles open by the Permissions API

This CL ensures that only at most one handle is open per (permission type, execution handle) pair.
It introduces a new class PermissionStatusListener that will hold the actual handle
and the PermissionStatus objects will hold a reference to this class.

This means that the PermissionType enum needs to be accessible in blink
and as such it's been moved from
`content/public/browser/permission_type.h`
to
`third_party/blink/public/common/permissions/permission_utils.h`

Additionally fix bugs uncovered along the way:
* If a PTZ (pan-tilt-zoom capable camera) request is made but it results
in a simple camera one, the Permissions API still tracks the PTZ
permission which would be incorrect.
* The New Tab Page doesn't properly get permission updates on the
PermissionStatus handle because of its weird URL. (`chrome://newtab`)

Fixed: 1122423
AX-Relnotes: n/a

Change-Id: Ieb5e9c7203f7bf3101a41af718a7d211b8bb40f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3359620
Reviewed-by: Ravjit Uppal <ravjit@chromium.org>
Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#995106}
28 files changed
tree: 15541e789213f5721a725c4ac271fa5f8a7760a6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.