commit | bf123c12c50993a3095dd732c551cf14a79ae4a0 | [log] [tgz] |
---|---|---|
author | Hui Yingst <nigi@chromium.org> | Fri Jan 22 03:28:46 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 22 03:28:46 2021 |
tree | abdbd686314d63662475db7d105c112784fdc410 | |
parent | 733d3121e2cfc222b24aaa9e7c991d0fb25f7f07 [diff] |
Handle null coordinates from XYZ named destination from a URL. Currently PDFiumEngine::GetNamedDestination() uses the public API FPDFDest_GetView() to get a named destination's view, which outputs 0 if a parameter is null. However, for the x and y coordinates from an XYZ named destination, 0 is a valid input while null should be treated as an empty input. This CL adds a string `xyz_params` in PDFEngine::NamedDestination so that null parameters can be passed to the viewport and get treated differently from 0 for x and y coordinates. Bug: 1157061, 1163701 Change-Id: I81a5a7c4b9c895263e580473a68a070e8b7965dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634130 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#845914}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.