[go: nahoru, domu]

media/gpu: Support keyframeless VP9 resolution changes for testing

VP9 verification sets "frm_resize" and "sub8x8_sf" [1] change
resolutions mid-stream without Key-frames. This is an arcane
feature and rare in the wild, where the rule is to have keyframes
to signal new resolutions.

ToT VP9Decoder considers any resolution changes a kConfigChange,
which causes the client to drop reference frames and reallocate
surfaces and context(s). But VA-API VideoDecoders on Intel and
AMD do support reusing the current context and surfaces for
smaller resolutions; https://crrev.com/c/4032552 did just that,
hence verifying the test vectors, but breaking DRM overlays ([2]),
so it was reverted.

In the large scheme of things, though, we'd rather reallocate the
context and surfaces when the resolution decreases (to have a
smaller mem footprint, not to mention to keep DRM overlays working),
rather than reusing things just to satisfy a theoretical concern.

So after a few tries at fixing this in code ([3,4] - ugly stuff),
I decided to give up and take up the suggestion in [5] to make
this a test only feature. With that, this CL adds a test flag and
sets it from v_d_a_tests code.

[1] https://www.webmproject.org/vp9/levels/#test-descriptions
[2] I dug into this for a while and I believe this was due to
VAAPI reusing |coded_size| and reducing the visible area while
the DRM API really needed both to be accurate. Maybe I'll dig
some more and try to find a repro case to file a bug.
Also note that FFmpeg+VA_API does support this non-reallocation
mode but would have the same DRM overlays issue if it was to
support them.
[3] https://crrev.com/c/4409593
[4] https://crrev.com/c/4437095
[5] https://crrev.com/c/4409593/2/media/gpu/vaapi/vaapi_video_decoder.cc#1145

Bug: b:207057398

Change-Id: Idb920f9e8e12704148cacc68befd5c5fb480e0ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4444189
Commit-Queue: Miguel Casas-Sanchez <mcasas@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1135030}
9 files changed
tree: 7377b041a53e17d76b1ce0bb0c82751dc0128154
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.