| commit | c500339d37c0b3c682ab1af1521020df83b9a334 | [log] [tgz] |
|---|---|---|
| author | Kurt Horimoto <kkhorimoto@google.com> | Wed Jun 26 22:09:33 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Jun 26 22:09:33 2019 |
| tree | 60eb2cb39bb1758acabb509c0caf0bde4fd05ac8 | |
| parent | 916b04a895b59e771de45481dafa0cce7e07622c [diff] |
[iOS] Only present when the presentation context is active. Previously, when the OverlayPresentationContext's coordinator is reset, the presented UI was dismissed without notifying the presenter. This CL updates the implementation to have OverlayPresenter drive the dismissal when the coordinator is reset. This allows for the presenter to be aware of all presentation/dismissal events so that its observers can be notified when they occur (e.g. at the end of the tab grid => BVC transition animation). To pipe this information back to OverlayPresenter, the presentation context exposes IsActive(), which describes whether the context is currently able to present. When a coordinator is provided to the context implementation, it notifies the presenter via observation that it has become active, which triggers presentation. When the coordinator is reset to nil upon the BVC leaving the window, the presenter is again notified via observation that the context is deactivating, which triggers dismissal. Bug: 941745 Change-Id: If06a9cd2aed18f34cf820423b42f24df78d22eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672173 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#672685}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .