commit | c516a4c191162b237ed6241cc37c84c90856669b | [log] [tgz] |
---|---|---|
author | Bo Liu <boliu@chromium.org> | Sun Apr 12 12:35:18 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Sun Apr 12 12:35:18 2020 |
tree | 94e639d017e8857f2196cae60c7feca5aacb7341 | |
parent | 01abb37385c52d37fc2d53b593af69cc81b037dc [diff] |
weblayer: Mark profile for deletion It is unsafe and generally not possible to delete the profile data of a profile that has already been "loaded". The only safe implementation is to mark the profile data as deleted, wait until the next time browser process starts, ensure the profile data is not loaded, and find a time to delete the data. This CL implements this for weblayer. * Deletion marker are empty files in <data>/profiles_to_delete matching the directory names of profiles. If <data>/profiles_to_delete/foo exists, then <data>/profiles/foo is marked for deletion. * If client create with a name (say "foo") matching a deleted profile, will try to linearly check for directory with a suffix (eg "foo.1", "foo.2", etc) until a directory that is not marked for deletion is found. "." is not part of a valid profile name, so there is no risk of collision. * Now DestroyAndDeleteDataFromDisk will mark the profile for deletion, and only remove data with BrowsingDataRemover. It will not attempt to delete the profile directory. * Nuke and Mark are run in the same SequencedTaskRunner to ensure Nuke is called first in a process before any mark. This ensures Nuke will never remove a newly marked Profile during the current process's lifetime. * Nuke will delete the data and cache directories first, and only remove the marker if both succeeds. This ensures there is no race in reusing a profile path. Add weblayer_unittests and add some unit tests for profile_disk_operations. Bug: 1065585 Change-Id: I4b936c9a1f31da56612095bb1088b93232c5751f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140101 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#758430}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.