[go: nahoru, domu]

Additional improvements of the new Incognito NTP

Changes in this CL:
1. Remove the lighter font from the title and subtitle (this is
   a leftover from the previous NTP).

2. Remove the trailing newline after the third bulletpoint. This made
   the bottom margin artificially larger.

3. Move the layout code from the onMeasure() to the onLayout() phase
   where it semantically belongs. Additionally, call
   setLayoutParams() after changing LayoutParams of a View (otherwise
   the change would not be registered).

4. If the screen is wide and the two sets of bulletpoints together
   are not too wide, arrange them next to each other by wrapping
   them in a linear layout.

5. If the bulletpoints are arranged next to each other, make the
   subtitle width equal to them. NOTE: The first layout pass calculates
   the width incorrectly by 10dp. I am still not sure why, so this is
   fixed in a hacky way for now.

6. Remove the ternary rule for padding-bottom (32/48/72 dp) in favor
   of a simpler binary one (32/72 dp) after feedback from the UX.

7. Resolve the TODO about the icon size (fortunately, it's a no-op).

BUG=693525

Review-Url: https://codereview.chromium.org/2963523002
Cr-Commit-Position: refs/heads/master@{#483694}
2 files changed