Reland of Don't explicitly force chromium_win_pch to 0 in clang builds. (patchset #1 id:1 of https://codereview.chromium.org/1760843002/ )
Reason for revert:
Should be better after the last gyp roll.
Original issue's description:
> Revert of Don't explicitly force chromium_win_pch to 0 in clang builds. (patchset #1 id:1 of https://codereview.chromium.org/1758143002/ )
>
> Reason for revert:
> Made the clang-cl/tot bots fail with:
>
> In file included from <built-in>:322:
> <command line>(70,10) : error: #include resolved using non-portable Microsoft search rules as: ..\..\build/precompile.h [-Werror,-Wmicrosoft-include]
> #include "precompile.h"
> ^
>
> Original issue's description:
> > Don't explicitly force chromium_win_pch to 0 in clang builds.
> >
> > clang-cl currenlty ignores /Yc, so this isn't needed (and it isn't done in
> > gn builds). Once clang-cl will support /Yc, we'll want to use it, so make
> > sure it's there.
> >
> > BUG=none
> >
> > Committed: https://crrev.com/02bbff06ffbaaaf20d5fcc58fd95b749431e19b9
> > Cr-Commit-Position: refs/heads/master@{#378950}
>
> TBR=hans@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=none
>
> Committed: https://crrev.com/1ef631665cc1ea9e4d1b509eb8fc7d597390a204
> Cr-Commit-Position: refs/heads/master@{#378980}
TBR=hans@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=none
Review URL: https://codereview.chromium.org/1769663002
Cr-Commit-Position: refs/heads/master@{#379581}
1 file changed