commit | ca9c99310e1b872be541bc2d3fd4c8d71ff7edc0 | [log] [tgz] |
---|---|---|
author | Alan Screen <awscreen@chromium.org> | Mon Nov 21 19:31:26 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Nov 21 19:31:26 2022 |
tree | fc4b57b44ba7ab84a231e9de9ae4b996ff9cb6b8 | |
parent | 77da2d96474a07f62f63a7c4c9da19b1daa0de27 [diff] |
Reland "Invoke service-based cancel for printing jobs" This is a reland of commit 5201bfbd1425d2f4ff0b72fdb89e791c37ddc826 Includes a fix to ensure that the PrintJob object still has a reference for the duration of OnDidCancel(). This protects against that object and the associated TestPrintJobWorkerOop from getting deleted before the call returns back the rest of processing in OnDidCancel(). Original change's description: > Invoke service-based cancel for printing jobs > > When the Print Backend Service has a failure during printing it has > been deleting the associated document data structure. This can lead > to use-after-free scenarios when multiple calls are already queued up > for processing and an error happens in an earlier stage that is > happening on a task runner. > > Update the service to do a local cancel on the printing context, but > refrain from deleting the associated document data structure. The > service now relies upon the browser process to notify it with a Cancel > call that is a signal to reclaim the document data resources. > > Change-Id: I1e5d643e576a81340c985770f8d4bc19add59c3e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3658489 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Alan Screen <awscreen@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1073583} Fixed: 1326580 Change-Id: I3970a00715fe19c6c8e9b809fe18b535a084d0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4040026 Auto-Submit: Alan Screen <awscreen@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1074154}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.