commit | cbde21cc10818a0d9a2d4bf4c56900a37a3249d0 | [log] [tgz] |
---|---|---|
author | erikchen <erikchen@chromium.org> | Mon Oct 09 21:00:06 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Oct 09 21:00:06 2017 |
tree | 2013e07fa58de9b9c1f95b863350ceaef310a4ea | |
parent | 67e860874de9ad2016381be5cc08b80f69acac37 [diff] |
[Reland #1] Switch task manager to use the memory_instrumentation interface. The original CL caused a renderer hang for a macOS ASAN browser test. For an in-depth investigation, see https://bugs.chromium.org/p/chromium/issues/detail?id=771805. The root cause was two fold: * A logic error in the original CL incorrectly caused memory details to be refreshed when only the memory footprint needed to be refreshed. Fixed in this reland. * A logic error in the cocoa TaskManager caused memory details to always be refreshed. Fixed in https://chromium-review.googlesource.com/c/chromium/src/+/706197. This CL also contains a minor optimization - the task manager will only ever queue a single memory dump at a time. > The memory_instrumentation interface on the content_browser service exposes > cross-platform, consistent memory metrics that should also be used by the task > manager. > > This CL adds a new column to the task manager: Memory Footprint. See > https://docs.google.com/document/d/1PZyRzChnvkUNUB85Op46aqkFXuAGUJi751DJuB6O40g/edit# > for more details. > > Bug: 756276 > Reviewed-on: https://chromium-review.googlesource.com/646047 > Reviewed-by: Nick Carter <nick@chromium.org> > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506220} Change-Id: I6fc43d064206bc614c52f84515f73dd98832f122 Bug: Reviewed-on: https://chromium-review.googlesource.com/706336 Reviewed-by: Nick Carter <nick@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#507483}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .