commit | d4b990b9153ee9466c5df39951989cc743a0380b | [log] [tgz] |
---|---|---|
author | Erik Chen <erikchen@chromium.org> | Mon Mar 11 22:58:41 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 11 22:58:41 2024 |
tree | 383382a0462bca9a3b6129764083df9c626d7eda | |
parent | daa14b20a7662f870dfd781d34587f95740b4c3e [diff] |
[Merge to 6312] Fix crash in LoginHandlerViews. The destructor of WebContents can trigger WebContentsObserver::DidFinishNavigation. This in turn can trigger the LoginTabHelper process for showing a Loginhandler. At this point, the WebContentsModalDialogManager has already been destroyed so the http auth dialog can no longer be shown. (cherry picked from commit 6ce85a09d6a6435735bd774fba7ff508e2fddce1) Change-Id: I5577a1d2cbeae034ad2217f1de546f459eb4885f Bug: 328388128, 328462789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5355654 Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1270490} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5362262 Cr-Commit-Position: refs/branch-heads/6312@{#534} Cr-Branched-From: 6711dcdae48edaf98cbc6964f90fac85b7d9986e-refs/heads/main@{#1262506}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.