commit | d4e153d930f3bfed1eaf22dcd75fb07af647aff5 | [log] [tgz] |
---|---|---|
author | Matt Menke <mmenke@chromium.org> | Fri Mar 05 18:16:38 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Mar 05 18:16:38 2021 |
tree | 55af8562223fdcd257900cf811ace4a5598fd99f | |
parent | d9a4766a0f55f67264816351dd88f14723af7ffa [diff] |
Add histograms to measure "unsafe" hostnames. "Unsafe" hostnames have numeric TLDs but are not IPv4. e.g. "foo.127.1". When the final two components are numeric, then converting an origin to a SchemefulSite and back results in a different origin. We want to get some rough measurement of usage of these before updating the URL spec to consider them invalid. This CL adds logging of unsafe hostnames in the following locations: * URL construction (numbers here aren't terribly meaningful, but not all URLs makes it to the network layer). * DNS lookup success/failure. * File URL request success/failure. Bug: 1149194 Change-Id: I7d4d4a28461be1c1c7d6a4ca0e4dc92bb1fa332d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2723071 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#860291}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.