| commit | d80bfad9daece5ed23493a9f2a94858efd8f546f | [log] [tgz] |
|---|---|---|
| author | Egor Pasko <pasko@chromium.org> | Thu Sep 10 21:53:06 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Sep 10 21:53:06 2020 |
| tree | 08a3d6cbe1f615ab3f290fe873c39fa33ca12b13 | |
| parent | cc065a1487363be7c58f09afbdb6ec9c3c413568 [diff] |
Orderfile: run _GitStash only on bots, simplify --public When running on buildbot, we always use the internal version. The git stash/unstash/commit/push should be avoided when running locally (options.buildbot=False). In the public repository, the OrderfileUpdater should be able to upload files, it was useful just once. With this, the OrderfileNoopUpdater looks unnecessary, since we replace OrderfileUpdater in the internal repo anyway, so remove it. Otherwise the split of functionality between the public and the internal OrderfileUpdater is accidental. Not revisiting it here. Bug: None Change-Id: Icd0fc9ed69d0def8e1fa9cfd1be05083f7c9cbf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403469 Reviewed-by: Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#805911}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.