commit | d8ec893735d0bc1424f0f16a8efcf4c158a8fa43 | [log] [tgz] |
---|---|---|
author | Łukasz Anforowicz <lukasza@chromium.org> | Thu Jan 11 23:06:07 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jan 11 23:06:07 2018 |
tree | 2d1dade60585801ca5f79fb2ccdcb18b368a3abc | |
parent | 20b6df783d5775f40c2fcfc39f5ecf54920b75a0 [diff] |
Revert "[reland] CanCommitOrigin tightening: match origin lock (if present)." This reverts commit 931f616caaad085f34e0d8df0b77789e3f9c8146. Reason for revert: We've gathered 20 crash reports - let's investigate them before relanding again. Original change's description: > [reland] CanCommitOrigin tightening: match origin lock (if present). > > This CL makes RenderFrameHostImpl::CanCommitOrigin check if the current > renderer process has an origin lock - if yes, then the lock has to match > the origin reported by the renderer in the DidCommitProvisionalLoad IPC. > > This CL makes additional tweaks to support LoadDataWithBaseURL. Such > navigations commit with origin = <base_url argument>. Before this CL, > such navigations would use site_url = data:... and in site-per-process > mode would lock the renderer to the data: origin - this would lead to > renderer kills after the CanCommitOrigin changes done by this CL. > Therefore this CL also makes sure that LoadDataWithBaseURL navigations > use site_url = <base url>. This is accomplished by taking into account > the base url in NavigationRequest::OnResponseStarted and > NavigationControllerImpl::Reload. > > This CL also tweaks unit tests, to make sure the simulated navigations > are compatible with the new CanCommitOrigin tightening. > > This is a reland of r526198, after adding extra logging > of requested_site_url from CanCommitOrigin. > > Bug: 770239, 797968 > Change-Id: I5783a3e32e6313fa5db5c88f55ebdc389843afc0 > Reviewed-on: https://chromium-review.googlesource.com/846342 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#528514} TBR=alexmos@chromium.org,lukasza@chromium.org Change-Id: Id2245895c1ba8dfa0f6d9a03bbefba1b3c49c9c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 770239, 797968 Reviewed-on: https://chromium-review.googlesource.com/862165 Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#528798}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .