[go: nahoru, domu]

Revert "[reland] CanCommitOrigin tightening: match origin lock (if present)."

This reverts commit 931f616caaad085f34e0d8df0b77789e3f9c8146.

Reason for revert: We've gathered 20 crash reports - let's investigate them before relanding again.

Original change's description:
> [reland] CanCommitOrigin tightening: match origin lock (if present).
> 
> This CL makes RenderFrameHostImpl::CanCommitOrigin check if the current
> renderer process has an origin lock - if yes, then the lock has to match
> the origin reported by the renderer in the DidCommitProvisionalLoad IPC.
> 
> This CL makes additional tweaks to support LoadDataWithBaseURL.  Such
> navigations commit with origin = <base_url argument>.  Before this CL,
> such navigations would use site_url = data:... and in site-per-process
> mode would lock the renderer to the data: origin - this would lead to
> renderer kills after the CanCommitOrigin changes done by this CL.
> Therefore this CL also makes sure that LoadDataWithBaseURL navigations
> use site_url = <base url>.  This is accomplished by taking into account
> the base url in NavigationRequest::OnResponseStarted and
> NavigationControllerImpl::Reload.
> 
> This CL also tweaks unit tests, to make sure the simulated navigations
> are compatible with the new CanCommitOrigin tightening.
> 
> This is a reland of r526198, after adding extra logging
> of requested_site_url from CanCommitOrigin.
> 
> Bug: 770239, 797968
> Change-Id: I5783a3e32e6313fa5db5c88f55ebdc389843afc0
> Reviewed-on: https://chromium-review.googlesource.com/846342
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#528514}

TBR=alexmos@chromium.org,lukasza@chromium.org

Change-Id: Id2245895c1ba8dfa0f6d9a03bbefba1b3c49c9c2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 770239, 797968
Reviewed-on: https://chromium-review.googlesource.com/862165
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528798}
6 files changed