| commit | d3117118f61720ed869bbc111df4e2c6e35a492a | [log] [tgz] |
|---|---|---|
| author | Jonathan Ross <jonross@chromium.org> | Fri Feb 17 16:42:09 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Feb 17 16:42:09 2023 |
| tree | 7d2ceb284c4d5af9c1ad8674307480eab2430cba | |
| parent | 86e64eead9ce837fef83771407006f34ee17ceb1 [diff] |
Implement OnBeginFrameAcks This change updates CompositorFrameSinkClient::OnBeginFrame to also take an array of ReturnedResource. When the Viz feature::OnBeginFrameAcks is enabled the OnBeginFrame message will act as both DidReceiveCompositorFrameAck and ReclaimResources. Except during teardown, when ReclaimResources will be sent directly. CompositorFrameSinkSupport has been updated to have some initial differentiation for handling BeginFrameArgs::kManualSourceId. Some tests such as blink_web_tests are using two BeginFrameSources. One is manual, and the tests are performing updates in response to the Ack. For this testing style we still send DidReceiveCompositorFrameAck immediately, as otherwise the manual frames can get too backed up. Clients have been updated to call their own DidReceiveCompositorFrameAck and ReclaimResources in response to the OnBeginFrame. In future work we will analysis the side-effects of these methods to see abouth further reduction in post-tasks. viz_unittests have been updated to be parameterized to test both modes, with changed mock call expectations. Bug: 1399880 Change-Id: Idf003d04474391ba0afeade30ba5b72797670e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4107129 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> Reviewed-by: Bo Liu <boliu@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/main@{#1106819}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.