[go: nahoru, domu]

Improve support for reading android virtual content uri as FilePath

go/clank-files-clipboard-drag-drop

When chrome does drag-drop of an image out of a renderer, it saves the
image in memory as a virtual content-uri.  This CL improves support for
accessing the virtual content-uri.

The DropDataProvider adds implementation of ContentProvider#openAssetFile()
which returns an AssetFileDescriptor with the valid length.

ContentUriUtils.getAssetFileDescriptor() is fixed to use
ContentResolver#openAssetFileDescriptor() which will include the valid
length, and adds a utility function getContentUriFileSize() which is used by file_util_posix.cc if fstat returns size=0.

LocalFileStreamReader which is used when a renderer fetches the blob
contents of a dropped file is changed to avoid calling seek() when
initial offset is zero, and seek is not required.  Any call to seek()
fails on android for a virtual file.

Bug: b/350860794
Low-Coverage-Reason: ContentUriUtils.java changes tested manually
Change-Id: I9842d428c62ecbb3b9542dcd1a293b31791dbdf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5679910
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Shu Yang <shuyng@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1324600}
7 files changed
tree: 5c73dbf83d775dc8c9dc54e371bc008a3c2a6fdb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.