commit | dae425074603cb36d07f8e0e91d0d1e5b4a4114e | [log] [tgz] |
---|---|---|
author | Justin Novosad <junov@chromium.org> | Thu Nov 11 19:50:43 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Nov 11 19:50:43 2021 |
tree | b2ff5391efd3a6e36641b089e28fdbff160d1055 | |
parent | 08a4fd7bd642271b6d068aca54eb18e82f867041 [diff] |
Fix race when drawing video frames to 2d canvas. Without this change there are possible races in GPU resource access. Most notably PaintCanvasVideoRenderer::Paint flushes the destination canvas after having drawn a video frame into it because the source image buffer's content is ephemeral and is not protected by any locking or synchronization mechanisms. Prior to this change, the call to PaintCanvas::flush in PaintCanvasVideoRenderer::Paint was not effective because RecordPaintCanvas::flush was a no-op. With this change, the flush request gets recorded so that calling code can take care of flushing. BUG=1254747 Change-Id: I2a99fb75f0a29d49079bba92c8f121a6c3005bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3231460 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/main@{#940884}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.