[go: nahoru, domu]

slim: Implement visible rect (clip in layer space)

Rename variables in recursive LayerTreeImpl::Draw to document the space
they are in. Eg clip -> clip_in_target.

Compute the transform parent to child by applying the layer transforms
in reverse, and in particular try to invert the transform matrix.
Restrict transforms to be 2D so that if the transforms is not
invertible, then it must transform a layer to be not be visible.
Rely on this fact to just skip the entire subtree and not deal with
non-invertible transforms.

Maintain a clip in layer space by using the parent to child transform
at each recursion level. Note only layers that has masks_to_bounds()
will clip the layer at the recursion.

It is then used as the visible rect in AppendQuads. Note viz expects
that the visible rect is a subset of layer bounds, so this will always
intersect with layer bounds regardless of masks_to_bounds().

Use RectF throughout and gfx::ToEnclosingRect at the end to avoid
any potential rounding errors.

Bug: 1408128
Change-Id: Idbd9a00aaaf93f3f1cad4832a22cf0a2f94372ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4295251
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Commit-Queue: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1112915}
13 files changed
tree: 67883e7edabbd3d02d06be659347e46f2a469f46
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.