commit | e566352ced9a0c006dcdffa77d32871bccb75612 | [log] [tgz] |
---|---|---|
author | Michael Thiessen <mthiesse@chromium.org> | Wed May 25 21:23:28 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed May 25 21:23:28 2022 |
tree | 52bde4d05595d5c0964e667f2decacff18666555 | |
parent | 93b0386d199826c4fab313c3a2a776dd00b3cf0b [diff] |
Revert "Delete UserGestureCarryover IPC" We're seeing sporadic reports of issues and at least one partner attributes this change to significant revenue loss, so let's revert while we work on the proper fix. See crbug.com/1325111, and discussion in crbug.com/1307848. (I've also heard from one company privately that this has caused issue for them). Original change's description: > Delete UserGestureCarryover IPC > > This was added a long time ago to allow async xhr requests to launch > app links. Later on, User Activation V2 made transient user activation > available to any sync/async "user API" in the LocalFrame (Window), > making xhr-request specific state propagation unnecessary. > > Note that integration tests for this exist in UrlOverridingTest. > > However, this deletion isn't entirely without risk - the Gesture > Carryover timeout was 10 seconds, while the transient activation > timeout is 5 seconds, meaning the effective timeout for this specific > case will be lowered and could theoretically pose problems under very > poor network conditions. Given we haven't felt the need to adjust the > 5s transient activation timeout for bad networks yet, I suspect this > should be fine. > > Bug: 1286053 > Change-Id: I14a7b72e0f219fde8b4bdc59090a1a1a4b63508c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3379287 > Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> > Reviewed-by: Bo Liu <boliu@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Charles Reis <creis@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/main@{#958748} Bug: 1286053 Change-Id: I28d41d2524a3a023d9aea890744c66d77222f9e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652643 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Michael Bai <michaelbai@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/main@{#1007567}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.