| commit | e7d5fffb570fa2563e08a6af0d9f1f42a76e3d74 | [log] [tgz] |
|---|---|---|
| author | David Roger <droger@chromium.org> | Mon Feb 12 20:05:34 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Feb 12 20:05:34 2024 |
| tree | f30101c3bedd9f63d968cb2bf2e6e29079595ac3 | |
| parent | 4f8b43e9a428e4174033333b59b73c16be3dbe1b [diff] |
[Waffle] Run generate_search_engine_icons.py as part of the build The script generate_search_engine_icons.py is split in 3: - download_search_engine_icons.py: downloads search engine icons from gstatic server. Generates the grdp file. Ran manually when the icons are updated. - generate_search_engine_icons.py: generates the C++ code. Ran as part of the build. - search_engine_icons_utils.py: shared utilities. The refactoring involved changes such as: - removing global variables - creating helper functions `keyword_to_resource_name` and `get_used_engines_with_keywords` in `search_engine_icons_utils.py` to reduce code duplication - removed log messages so that nothing is logged during a successful build. Generated code: generated_icon_utils-inc.cc: http://gpaste/6017060839096320 generated_search_engine_resource_ids-inc.cc: https://paste.googleplex.com/5354399747014656 Change-Id: I21af4436508678208774010c499e85f659aaf00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5149090 Reviewed-by: Jack Yammine <jyammine@google.com> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/main@{#1259393}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.