commit | e9ab19ef8d981fd8a9a608f7397e73301b0fe19b | [log] [tgz] |
---|---|---|
author | luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> | Fri Nov 10 17:28:31 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Nov 10 17:28:31 2023 |
tree | 4bedf9e2a2387b652702c6bc9bd227f129c6ad73 | |
parent | a230bba2f7267f23c52665e2ede72d30410c0072 [diff] |
Revert "Revert "Refactor DestroySharedImage() for raster buffer providers"" This reverts commit 27e5288576bc4c4d226dff17d26fb6a9f1e38cdb. Reason for revert: LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8764795698775102353 Sample failed build: https://ci.chromium.org/b/8764795698775102353 If this is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?comment=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8764795698775102353&components=Tools%3ETest%3EFindit&labels=LUCI-Bisection-Wrong%2CPri-3%2CType-Bug&status=Available&summary=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5017748 Original change's description: > Revert "Refactor DestroySharedImage() for raster buffer providers" > > This reverts commit f685881ef6cbe4cece342b7d2a8c81358e5b5d8c. > > Reason for revert: Causing crashes on Windows GPU bots in https://crbug.com/1501374 > > Original change's description: > > Refactor DestroySharedImage() for raster buffer providers > > > > As part of a large scale refactorization that aims at introducing > > ClientSharedImage, this CL refactors several raster buffer providers > > to 1. use the new version of DestroySharedImage() (that accepts a > > ClientSharedImage parameter instead of a mailbox), and 2. make sure > > the ClientSharedImage created by CreateSharedImage() could persist > > until the calling of DestroySharedImage(). > > > > Bug: 1494911, 1499992 > > Change-Id: Ib1de7766fc30fd45516b22ec590711a6f34da31c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003181 > > Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> > > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1222586} > > Bug: 1494911, 1499992, 1501374 > Change-Id: I4d90425fc1aa1c057f1b865d14a1f1f1d32ce0d2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5017748 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Kyle Charbonneau <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1222991} > Bug: 1494911, 1499992, 1501374 Change-Id: I8d1160e02fbea140a7c306f0d9de8879d10ae9bc No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5021207 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1222996}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.